The patch titled
ufs: handle truncated pages
has been added to the -mm tree. Its filename is
ufs-handle-truncated-pages.patch
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this
------------------------------------------------------
Subject: ufs: handle truncated pages
From: Evgeniy Dushistov <dushistov@xxxxxxx>
ufs_get_locked_page is called twice in ufs code, one time in ufs_truncate
path(we allocated last block), and another time when fragments are
reallocated. In ideal world in the second case on allocation/free block
layer we should not know that things like `truncate' exists, but now with
such crutch like ufs_get_locked_page we can (or should?) skip truncated
pages.
Signed-off-by: Evgeniy Dushistov <dushistov@xxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---
fs/ufs/balloc.c | 2 +-
fs/ufs/util.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff -puN fs/ufs/balloc.c~ufs-handle-truncated-pages fs/ufs/balloc.c
--- a/fs/ufs/balloc.c~ufs-handle-truncated-pages
+++ a/fs/ufs/balloc.c
@@ -248,7 +248,7 @@ static void ufs_change_blocknr(struct in
if (likely(cur_index != index)) {
page = ufs_get_locked_page(mapping, index);
- if (IS_ERR(page))
+ if (!page || IS_ERR(page)) /* it was truncated or EIO */
continue;
} else
page = locked_page;
diff -puN fs/ufs/util.c~ufs-handle-truncated-pages fs/ufs/util.c
--- a/fs/ufs/util.c~ufs-handle-truncated-pages
+++ a/fs/ufs/util.c
@@ -251,7 +251,6 @@ struct page *ufs_get_locked_page(struct
{
struct page *page;
-try_again:
page = find_lock_page(mapping, index);
if (!page) {
page = read_cache_page(mapping, index,
@@ -271,7 +270,8 @@ try_again:
/* Truncate got there first */
unlock_page(page);
page_cache_release(page);
- goto try_again;
+ page = NULL;
+ goto out;
}
if (!PageUptodate(page) || PageError(page)) {
_
Patches currently in -mm which might be from dushistov@xxxxxxx are
origin.patch
ufs-ufs_get_locked_patch-race-fix.patch
ufs-handle-truncated-pages.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
