The patch titled
ia64: panic if topology_init kzalloc fails
has been added to the -mm tree. Its filename is
ia64-panic-if-topology_init-kzalloc-fails.patch
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this
------------------------------------------------------
Subject: ia64: panic if topology_init kzalloc fails
From: Paul Jackson <pj@xxxxxxx>
There really is no sense trying to continue if the kzalloc of sysfs_cpus[]
fails in ia64 topology_init. The code calling into here doesn't check
errors very well, and one ends up with a nonobvious boot failure that
wastes peoples time debugging.
See for example the lkml thread at:
http://lkml.org/lkml/2006/3/2/215
Since the system is totally dead when this kzalloc fails, not having yet
even booted, might as well announce one's death boldly and plainly.
Signed-off-by: Paul Jackson <pj@xxxxxxx>
Cc: "Luck, Tony" <tony.luck@xxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---
arch/ia64/kernel/topology.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff -puN arch/ia64/kernel/topology.c~ia64-panic-if-topology_init-kzalloc-fails arch/ia64/kernel/topology.c
--- a/arch/ia64/kernel/topology.c~ia64-panic-if-topology_init-kzalloc-fails
+++ a/arch/ia64/kernel/topology.c
@@ -67,10 +67,8 @@ static int __init topology_init(void)
#endif
sysfs_cpus = kzalloc(sizeof(struct ia64_cpu) * NR_CPUS, GFP_KERNEL);
- if (!sysfs_cpus) {
- err = -ENOMEM;
- goto out;
- }
+ if (!sysfs_cpus)
+ panic("kzalloc in topology_init failed - NR_CPUS too big?");
for_each_present_cpu(i) {
if((err = arch_register_cpu(i)))
_
Patches currently in -mm which might be from pj@xxxxxxx are
sched-build_sched_domains-fix.patch
ia64-panic-if-topology_init-kzalloc-fails.patch
cpuset-oom-panic-fix.patch
oom-cpuset-hint.patch
sched-force-sbin-init-off-isolated-cpus.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
