The patch titled
Fix reference of uninitialised memory in ata_device_add()
has been added to the -mm tree. Its filename is
via-sata-oops-on-init.patch
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this
------------------------------------------------------
Subject: Fix reference of uninitialised memory in ata_device_add()
From: Dave Jones <davej@xxxxxxxxxx>
ata_device_add fails, calls ata_host_remove with pointers to unitialized
memory.
Signed-off-by: Dave Jones <davej@xxxxxxxxxx>
Cc: Jeff Garzik <jeff@xxxxxxxxxx>
Cc: Tejun Heo <htejun@xxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---
drivers/scsi/libata-core.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff -puN drivers/scsi/libata-core.c~via-sata-oops-on-init drivers/scsi/libata-core.c
--- a/drivers/scsi/libata-core.c~via-sata-oops-on-init
+++ a/drivers/scsi/libata-core.c
@@ -5461,6 +5461,7 @@ int ata_device_add(const struct ata_prob
ap = ata_host_add(ent, host_set, i);
+ host_set->ports[i] = ap;
if (!ap)
goto err_out;
@@ -5468,7 +5469,6 @@ int ata_device_add(const struct ata_prob
if (i == 1 && ent->irq2)
irq_line = ent->irq2;
- host_set->ports[i] = ap;
xfer_mode_mask =(ap->udma_mask << ATA_SHIFT_UDMA) |
(ap->mwdma_mask << ATA_SHIFT_MWDMA) |
(ap->pio_mask << ATA_SHIFT_PIO);
@@ -5594,6 +5594,8 @@ int ata_device_add(const struct ata_prob
err_out:
for (i = 0; i < count; i++) {
+ if (!host_set->ports[i])
+ break;
ata_host_remove(host_set->ports[i], 1);
scsi_host_put(host_set->ports[i]->host);
}
_
Patches currently in -mm which might be from davej@xxxxxxxxxx are
git-agpgart.patch
git-cpufreq.patch
remove-silly-messages-from-input-layer.patch
git-kbuild.patch
via-sata-oops-on-init.patch
debug-variants-of-linked-list-macros.patch
post-halloween-doc.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
