The patch titled
efs: Remove incorrect unlock_kernel from failure path in efs_symlink_readpage()
has been added to the -mm tree. Its filename is
remove-incorrect-unlock_kernel-from-failure-path-in.patch
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this
------------------------------------------------------
Subject: efs: Remove incorrect unlock_kernel from failure path in efs_symlink_readpage()
From: Josh Triplett <josht@xxxxxxxxxx>
If efs_symlink_readpage hits the -ENAMETOOLONG error path, it will call
unlock_kernel without ever having called lock_kernel(); fix this by
creating and jumping to a new label fail_notlocked rather than the fail
label used after calling lock_kernel().
Signed-off-by: Josh Triplett <josh@xxxxxxxxxxxxxxx>
Cc: Marcelo Tosatti <marcelo.tosatti@xxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---
fs/efs/symlink.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff -puN fs/efs/symlink.c~remove-incorrect-unlock_kernel-from-failure-path-in fs/efs/symlink.c
--- a/fs/efs/symlink.c~remove-incorrect-unlock_kernel-from-failure-path-in
+++ a/fs/efs/symlink.c
@@ -22,7 +22,7 @@ static int efs_symlink_readpage(struct f
err = -ENAMETOOLONG;
if (size > 2 * EFS_BLOCKSIZE)
- goto fail;
+ goto fail_notlocked;
lock_kernel();
/* read first 512 bytes of link target */
@@ -47,6 +47,7 @@ static int efs_symlink_readpage(struct f
return 0;
fail:
unlock_kernel();
+fail_notlocked:
SetPageError(page);
kunmap(page);
unlock_page(page);
_
Patches currently in -mm which might be from josht@xxxxxxxxxx are
remove-incorrect-unlock_kernel-from-allocation.patch
remove-incorrect-unlock_kernel-from-failure-path-in.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
