The patch titled
fix bad macro param in timer.c
has been added to the -mm tree. Its filename is
fix-bad-macro-param-in-timerc.patch
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this
------------------------------------------------------
Subject: fix bad macro param in timer.c
From: Steven Rostedt <rostedt@xxxxxxxxxxx>
We have
#define INDEX(N) (base->timer_jiffies >> (TVR_BITS + N * TVN_BITS)) & TVN_MASK
and it's used via
list = varray[i + 1]->vec + (INDEX(i + 1));
So, due to underparenthesisation, this INDEX(i+1) is now a ... (TVR_BITS + i
+ 1 * TVN_BITS)) ...
So this bugfix changes behaviour. Why did it work before?
Signed-off-by: Steven Rostedt <rostedt@xxxxxxxxxxx>
Cc: Oleg Nesterov <oleg@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---
kernel/timer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN kernel/timer.c~fix-bad-macro-param-in-timerc kernel/timer.c
--- a/kernel/timer.c~fix-bad-macro-param-in-timerc
+++ a/kernel/timer.c
@@ -408,7 +408,7 @@ static int cascade(tvec_base_t *base, tv
* This function cascades all vectors and executes all expired timer
* vectors.
*/
-#define INDEX(N) (base->timer_jiffies >> (TVR_BITS + N * TVN_BITS)) & TVN_MASK
+#define INDEX(N) ((base->timer_jiffies >> (TVR_BITS + (N) * TVN_BITS)) & TVN_MASK)
static inline void __run_timers(tvec_base_t *base)
{
_
Patches currently in -mm which might be from rostedt@xxxxxxxxxxx are
remove-unnecessary-barrier-in-rtc_get_rtc_time.patch
fix-bad-macro-param-in-timerc.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
