+ let-warn_on-warn_on_once-return-the-condition.patch added to -mm tree

[akpm@xxxxxxxx]

The patch titled

     Let WARN_ON/WARN_ON_ONCE return the condition

has been added to the -mm tree.  Its filename is

     let-warn_on-warn_on_once-return-the-condition.patch

See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this

------------------------------------------------------
Subject: Let WARN_ON/WARN_ON_ONCE return the condition
From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>

Letting WARN_ON/WARN_ON_ONCE return the condition means that you could do

if (WARN_ON(blah)) {
	handle_impossible_case
}

Rather than

if (unlikely(blah)) {
	WARN_ON(1)
	handle_impossible_case
}

I checked all the newly added WARN_ON_ONCE users and none of them test the
return status so we can still change it.

Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Cc: Ingo Molnar <mingo@xxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---

 include/asm-generic/bug.h |   24 ++++++++++++------------
 include/asm-powerpc/bug.h |   12 +++++++-----
 2 files changed, 19 insertions(+), 17 deletions(-)

diff -puN include/asm-generic/bug.h~let-warn_on-warn_on_once-return-the-condition include/asm-generic/bug.h
--- a/include/asm-generic/bug.h~let-warn_on-warn_on_once-return-the-condition
+++ a/include/asm-generic/bug.h
@@ -16,12 +16,14 @@
 #endif
 
 #ifndef HAVE_ARCH_WARN_ON
-#define WARN_ON(condition) do { \
-	if (unlikely((condition)!=0)) { \
+#define WARN_ON(condition) unlikely({ \
+	int __ret_warn_on = (condition); \
+	if (unlikely(__ret_warn_on)) { \
 		printk("BUG: warning at %s:%d/%s()\n", __FILE__, __LINE__, __FUNCTION__); \
 		dump_stack(); \
 	} \
-} while (0)
+	__ret_warn_on; \
+})
 #endif
 
 #else /* !CONFIG_BUG */
@@ -34,21 +36,19 @@
 #endif
 
 #ifndef HAVE_ARCH_WARN_ON
-#define WARN_ON(condition) do { if (condition) ; } while(0)
+#define WARN_ON(condition) unlikely((condition))
 #endif
 #endif
 
 #define WARN_ON_ONCE(condition)				\
-({							\
+unlikely({						\
 	static int __warn_once = 1;			\
-	int __ret = 0;					\
+	int __ret_warn_once = (condition);		\
 							\
-	if (unlikely((condition) && __warn_once)) {	\
-		__warn_once = 0;			\
-		WARN_ON(1);				\
-		__ret = 1;				\
-	}						\
-	__ret;						\
+	if (likely(__warn_once))			\
+		if (WARN_ON(__ret_warn_once)) 		\
+			__warn_once = 0;		\
+	__ret_warn_once;				\
 })
 
 #ifdef CONFIG_SMP
diff -puN include/asm-powerpc/bug.h~let-warn_on-warn_on_once-return-the-condition include/asm-powerpc/bug.h
--- a/include/asm-powerpc/bug.h~let-warn_on-warn_on_once-return-the-condition
+++ a/include/asm-powerpc/bug.h
@@ -70,9 +70,10 @@ struct bug_entry *find_bug(unsigned long
 		    "i" (__FILE__), "i" (__FUNCTION__));	\
 } while (0)
 
-#define WARN_ON(x) do {						\
-	if (__builtin_constant_p(x)) {				\
-		if (x)						\
+#define WARN_ON(x) unlikely({					\
+	long __ret_warn_on = (x);				\
+	if (__builtin_constant_p(__ret_warn_on)) {		\
+		if (__ret_warn_on)				\
 			__WARN();				\
 	} else {						\
 		__asm__ __volatile__(				\
@@ -80,11 +81,12 @@ struct bug_entry *find_bug(unsigned long
 		".section __bug_table,\"a\"\n"			\
 		"\t"PPC_LONG"	1b,%1,%2,%3\n"			\
 		".previous"					\
-		: : "r" ((long)(x)),				\
+		: : "r" (__ret_warn_on),			\
 		    "i" (__LINE__ + BUG_WARNING_TRAP),		\
 		    "i" (__FILE__), "i" (__FUNCTION__));	\
 	}							\
-} while (0)
+	__ret_warn_on;						\
+})
 
 #define HAVE_ARCH_BUG
 #define HAVE_ARCH_BUG_ON
_

Patches currently in -mm which might be from herbert@xxxxxxxxxxxxxxxxxxx are

origin.patch
git-klibc.patch
lockdep-fix-sk_dst_check-deadlock.patch
git-cryptodev.patch
let-warn_on-warn_on_once-return-the-condition.patch

-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html