The patch titled
VFS: Remove redundant open-coded mode bit check in prepare_binfmt()
has been added to the -mm tree. Its filename is
vfs-remove-redundant-open-coded-mode-bit-check-in-prepare_binfmt.patch
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this
------------------------------------------------------
Subject: VFS: Remove redundant open-coded mode bit check in prepare_binfmt()
From: Trond Myklebust <Trond.Myklebust@xxxxxxxxxx>
The check in prepare_binfmt() for inode->i_mode & 0111 is redundant, since
open_exec() will already have done that.
Signed-off-by: Trond Myklebust <Trond.Myklebust@xxxxxxxxxx>
Cc: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
Cc: Christoph Hellwig <hch@xxxxxx>
Cc: Chris Wright <chrisw@xxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---
fs/exec.c | 6 ------
1 file changed, 6 deletions(-)
diff -puN fs/exec.c~vfs-remove-redundant-open-coded-mode-bit-check-in-prepare_binfmt fs/exec.c
--- a/fs/exec.c~vfs-remove-redundant-open-coded-mode-bit-check-in-prepare_binfmt
+++ a/fs/exec.c
@@ -919,12 +919,6 @@ int prepare_binprm(struct linux_binprm *
int retval;
mode = inode->i_mode;
- /*
- * Check execute perms again - if the caller has CAP_DAC_OVERRIDE,
- * generic_permission lets a non-executable through
- */
- if (!(mode & 0111)) /* with at least _one_ execute bit set */
- return -EACCES;
if (bprm->file->f_op == NULL)
return -EACCES;
_
Patches currently in -mm which might be from Trond.Myklebust@xxxxxxxxxx are
vfs-fix-accessfile-x_ok-in-the-presence-of-acls.patch
vfs-remove-redundant-open-coded-mode-bit-check-in-prepare_binfmt.patch
vfs-remove-redundant-open-coded-mode-bit-checks-in-open_exec.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
