The patch titled
Properly unregister reboot notifier in case of failure in ehci hcd
has been added to the -mm tree. Its filename is
properly-unregister-reboot-notifier-in-case-of-failure-in-ehci-hcd.patch
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this
------------------------------------------------------
Subject: Properly unregister reboot notifier in case of failure in ehci hcd
From: Aleksey Gorelov <dared1st@xxxxxxxxx>
If some problem occurs during ehci startup, for instance, request_irq
fails, echi hcd driver tries it best to cleanup, but fails to unregister
reboot notifier, which in turn leads to crash on reboot/poweroff. Below is
the patch against current git to fix this. I did not check if the same
problem existed for uhci/ohci host drivers.
Signed-off-by: Aleks Gorelov <dared1st@xxxxxxxxx>
Cc: David Brownell <david-b@xxxxxxxxxxx>
Cc: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
Cc: Greg KH <greg@xxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---
drivers/usb/host/ehci-hcd.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff -puN drivers/usb/host/ehci-hcd.c~properly-unregister-reboot-notifier-in-case-of-failure-in-ehci-hcd drivers/usb/host/ehci-hcd.c
--- a/drivers/usb/host/ehci-hcd.c~properly-unregister-reboot-notifier-in-case-of-failure-in-ehci-hcd
+++ a/drivers/usb/host/ehci-hcd.c
@@ -483,9 +483,6 @@ static int ehci_init(struct usb_hcd *hcd
}
ehci->command = temp;
- ehci->reboot_notifier.notifier_call = ehci_reboot;
- register_reboot_notifier(&ehci->reboot_notifier);
-
return 0;
}
@@ -499,7 +496,6 @@ static int ehci_run (struct usb_hcd *hcd
/* EHCI spec section 4.1 */
if ((retval = ehci_reset(ehci)) != 0) {
- unregister_reboot_notifier(&ehci->reboot_notifier);
ehci_mem_cleanup(ehci);
return retval;
}
@@ -560,6 +556,9 @@ static int ehci_run (struct usb_hcd *hcd
*/
create_debug_files(ehci);
+ ehci->reboot_notifier.notifier_call = ehci_reboot;
+ register_reboot_notifier(&ehci->reboot_notifier);
+
return 0;
}
_
Patches currently in -mm which might be from dared1st@xxxxxxxxx are
properly-unregister-reboot-notifier-in-case-of-failure-in-ehci-hcd.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
