- ib-ipath-fixes-a-bug-where-our-delay-for-eeprom-no.patch removed from -mm tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The patch titled

     IB/ipath: fixes a bug where our delay for EEPROM no longer works due to compiler reordering

has been removed from the -mm tree.  Its filename is

     ib-ipath-fixes-a-bug-where-our-delay-for-eeprom-no.patch

This patch was dropped because I don't have a dog in this fight

------------------------------------------------------
Subject: IB/ipath: fixes a bug where our delay for EEPROM no longer works due to compiler reordering
From: "Bryan O'Sullivan" <bos@xxxxxxxxxxxxx>

The mb() prevents the compiler from reordering on this function, with some
versions of gcc and -Os optimization.  The result is random failures in the
EEPROM read without this change.

Signed-off-by: Dave Olson <dave.olson@xxxxxxxxxx>
Signed-off-by: Bryan O'Sullivan <bryan.osullivan@xxxxxxxxxx>
Cc: "Michael S. Tsirkin" <mst@xxxxxxxxxxxxxx>
Cc: Roland Dreier <rolandd@xxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---

 drivers/infiniband/hw/ipath/ipath_eeprom.c |    1 +
 1 file changed, 1 insertion(+)

diff -puN drivers/infiniband/hw/ipath/ipath_eeprom.c~ib-ipath-fixes-a-bug-where-our-delay-for-eeprom-no drivers/infiniband/hw/ipath/ipath_eeprom.c
--- a/drivers/infiniband/hw/ipath/ipath_eeprom.c~ib-ipath-fixes-a-bug-where-our-delay-for-eeprom-no
+++ a/drivers/infiniband/hw/ipath/ipath_eeprom.c
@@ -186,6 +186,7 @@ bail:
  */
 static void i2c_wait_for_writes(struct ipath_devdata *dd)
 {
+	mb();
 	(void)ipath_read_kreg32(dd, dd->ipath_kregs->kr_scratch);
 }
 
_

Patches currently in -mm which might be from bos@xxxxxxxxxxxxx are

ib-ipath-fixes-a-bug-where-our-delay-for-eeprom-no.patch

-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel Newbies FAQ]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Photo]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux