The patch titled
Clean up coding style in taskstats interface
has been removed from the -mm tree. Its filename is
per-task-delay-accounting-taskstats-interface-fix-1.patch
This patch was dropped because it was folded into per-task-delay-accounting-taskstats-interface.patch
------------------------------------------------------
Subject: Clean up coding style in taskstats interface
From: Balbir Singh <balbir@xxxxxxxxxx>
On Mon, May 08, 2006 at 02:31:39PM -0700, Andrew Morton wrote:
> Balbir Singh <balbir@xxxxxxxxxx> wrote:
> >
> > +
> > + if ((rc = genl_register_ops(&family, &taskstats_ops)) < 0)
> > + goto err;
>
> rc = genl_register_ops(&family, &taskstats_ops);
> if (rc < 0)
> goto err;
>
> please.
Sure, here you go Andrew
I have updated the coding style as per your suggestion
Balbir Singh,
Linux Technology Center,
IBM Software Labs
Changelog
1. Split the complex if condition into
a. function call
b. check return status for error
Signed-off-by: Balbir Singh <balbir@xxxxxxxxxx>
Signed-off-by: Shailabh Nagar <nagar@xxxxxxxxxxxxxx>
Cc: Jes Sorensen <jes@xxxxxxx>
Cc: Peter Chubb <peterc@xxxxxxxxxxxxxxxxxx>
Cc: Erich Focht <efocht@xxxxxxxxxx>
Cc: Levent Serinol <lserinol@xxxxxxxxx>
Cc: Jay Lan <jlan@xxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---
kernel/taskstats.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff -puN kernel/taskstats.c~per-task-delay-accounting-taskstats-interface-fix-1 kernel/taskstats.c
--- devel/kernel/taskstats.c~per-task-delay-accounting-taskstats-interface-fix-1 2006-06-09 15:18:06.000000000 -0700
+++ devel-akpm/kernel/taskstats.c 2006-06-09 15:18:06.000000000 -0700
@@ -312,7 +312,8 @@ static int __init taskstats_init(void)
return rc;
family_registered = 1;
- if ((rc = genl_register_ops(&family, &taskstats_ops)) < 0)
+ rc = genl_register_ops(&family, &taskstats_ops);
+ if (rc < 0)
goto err;
return 0;
_
Patches currently in -mm which might be from balbir@xxxxxxxxxx are
origin.patch
per-task-delay-accounting-setup.patch
per-task-delay-accounting-sync-block-i-o-and-swapin-delay-collection.patch
per-task-delay-accounting-cpu-delay-collection-via-schedstats.patch
per-task-delay-accounting-utilities-for-genetlink-usage.patch
per-task-delay-accounting-taskstats-interface.patch
per-task-delay-accounting-taskstats-interface-fix-1.patch
per-task-delay-accounting-taskstats-interface-fix-2.patch
per-task-delay-accounting-taskstats-interface-tidy.patch
per-task-delay-accounting-delay-accounting-usage-of-taskstats-interface.patch
per-task-delay-accounting-documentation.patch
per-task-delay-accounting-proc-export-of-aggregated-block-i-o-delays.patch
per-task-delay-accounting-proc-export-of-aggregated-block-i-o-delays-warning-fix.patch
delay-accounting-taskstats-interface-send-tgid-once.patch
delay-accounting-taskstats-interface-send-tgid-once-fixes.patch
per-task-delay-accounting-avoid-send-without-listeners.patch
task-watchers-register-per-task-delay-accounting.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
