- genirq-add-chip-eoi-fastack-fasteoi-fix.patch removed from -mm tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The patch titled

     genirq: handle_fasteoi_irq(): do not ->mask()

has been removed from the -mm tree.  Its filename is

     genirq-add-chip-eoi-fastack-fasteoi-fix.patch

This patch was dropped because it was folded into genirq-add-chip-eoi-fastack-fasteoi-core.patch

------------------------------------------------------
Subject: genirq: handle_fasteoi_irq(): do not ->mask()
From: Ingo Molnar <mingo@xxxxxxx>


Ben noticed an inefficiency in the handle_fasteoi_irq() flow handler: it
does a spurious ->mask() call.  (That call is not needed - if something did
a disable_irq() then it would have masked the irq itself.)

I tested the fix on all affected fasteoi platforms: x86 and x86_64, on both
UP and SMP.

Signed-off-by: Ingo Molnar <mingo@xxxxxxx>
Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
Cc: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---

 kernel/irq/chip.c |    2 --
 1 file changed, 2 deletions(-)

diff -puN kernel/irq/chip.c~genirq-add-chip-eoi-fastack-fasteoi-fix kernel/irq/chip.c
--- a/kernel/irq/chip.c~genirq-add-chip-eoi-fastack-fasteoi-fix
+++ a/kernel/irq/chip.c
@@ -327,8 +327,6 @@ handle_fasteoi_irq(unsigned int irq, str
 	spin_lock(&desc->lock);
 	desc->status &= ~IRQ_INPROGRESS;
 out:
-	if (unlikely(desc->status & IRQ_DISABLED))
-		desc->chip->mask(irq);
 	desc->chip->eoi(irq);
 
 	spin_unlock(&desc->lock);
_

Patches currently in -mm which might be from mingo@xxxxxxx are

origin.patch
genirq-rename-desc-handler-to-desc-chip.patch
genirq-sem2mutex-probe_sem-probing_active.patch
genirq-cleanup-merge-irq_affinity-into-irq_desc.patch
genirq-cleanup-remove-irq_descp.patch
genirq-cleanup-remove-fastcall.patch
genirq-cleanup-misc-code-cleanups.patch
genirq-cleanup-reduce-irq_desc_t-use-mark-it-obsolete.patch
genirq-cleanup-include-linux-irqh.patch
genirq-cleanup-merge-irq_dir-smp_affinity_entry-into-irq_desc.patch
genirq-cleanup-merge-pending_irq_cpumask-into-irq_desc.patch
genirq-cleanup-turn-arch_has_irq_per_cpu-into-config_irq_per_cpu.patch
genirq-debug-better-debug-printout-in-enable_irq.patch
genirq-add-retrigger-irq-op-to-consolidate-hw_irq_resend.patch
genirq-doc-comment-include-linux-irqh-structures.patch
genirq-doc-handle_irq_event-and-__do_irq-comments.patch
genirq-cleanup-no_irq_type-cleanups.patch
genirq-doc-add-design-documentation.patch
genirq-add-genirq-sw-irq-retrigger.patch
genirq-add-irq_noprobe-support.patch
genirq-add-irq_norequest-support.patch
genirq-add-irq_noautoen-support.patch
genirq-update-copyrights.patch
genirq-core.patch
genirq-msi-fixes-2.patch
genirq-add-irq-chip-support.patch
genirq-add-handle_bad_irq.patch
genirq-add-irq-wake-power-management-support.patch
genirq-add-sa_trigger-support.patch
genirq-cleanup-no_irq_type-no_irq_chip-rename.patch
genirq-more-verbose-debugging-on-unexpected-irq-vectors.patch
genirq-add-irq_type_sense_mask.patch
genirq-add-irq-chip-support-fasteoi-handler-handle-interrupt-disabling.patch
genirq-irq-document-what-an-irq-is.patch
genirq-add-chip-eoi-fastack-fasteoi-core.patch
genirq-add-chip-eoi-fastack-fasteoi-fix.patch

-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel Newbies FAQ]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Photo]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux