+ typo-in-drivers-net-e1000-e1000_hwc.patch added to -mm tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The patch titled

     Typo in drivers/net/e1000/e1000_hw.c

has been added to the -mm tree.  Its filename is

     typo-in-drivers-net-e1000-e1000_hwc.patch

See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this

------------------------------------------------------
Subject: Typo in drivers/net/e1000/e1000_hw.c
From: Eric Sesterhenn <snakebyte@xxxxxx>

Spotted by coverity (id #539), we should use the define with which the
array is defined.  We use min_agc as index for
e1000_igp_2_cable_length_table[IGP02E1000_AGC_LENGTH_TABLE_SIZE] This patch
also adds the -1 to make it safe so that we dont read past the end of the
array.

Signed-off-by: Eric Sesterhenn <snakebyte@xxxxxx>
Cc: John Ronciak <john.ronciak@xxxxxxxxx>
Cc: Jesse Brandeburg <jesse.brandeburg@xxxxxxxxx>
Cc: Jeff Kirsher <jeffrey.t.kirsher@xxxxxxxxx>
Cc: Auke Kok <auke-jan.h.kok@xxxxxxxxx>
Cc: Jeff Garzik <jeff@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---

 drivers/net/e1000/e1000_hw.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN drivers/net/e1000/e1000_hw.c~typo-in-drivers-net-e1000-e1000_hwc drivers/net/e1000/e1000_hw.c
--- a/drivers/net/e1000/e1000_hw.c~typo-in-drivers-net-e1000-e1000_hwc
+++ a/drivers/net/e1000/e1000_hw.c
@@ -6012,7 +6012,7 @@ e1000_get_cable_length(struct e1000_hw *
 {
     int32_t ret_val;
     uint16_t agc_value = 0;
-    uint16_t cur_agc, min_agc = IGP01E1000_AGC_LENGTH_TABLE_SIZE;
+    uint16_t cur_agc, min_agc = IGP02E1000_AGC_LENGTH_TABLE_SIZE - 1;
     uint16_t max_agc = 0;
     uint16_t i, phy_data;
     uint16_t cable_length;
_

Patches currently in -mm which might be from snakebyte@xxxxxx are

origin.patch
git-gfs2.patch
typo-in-drivers-net-e1000-e1000_hwc.patch
git-wireless.patch

-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel Newbies FAQ]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Photo]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux