The patch titled md: set desc_nr correctly for version-1 superblocks has been added to the -mm tree. Its filename is md-set-desc_nr-correctly-for-version-1-superblocks.patch See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out what to do about this ------------------------------------------------------ Subject: md: set desc_nr correctly for version-1 superblocks From: NeilBrown <neilb@xxxxxxx> This has to be done in ->load_super, not ->validate_super Without this, hot-adding devices to an array doesn't always work right - though there is a work around in mdadm-2.5.2 to make this less of an issue. Signed-off-by: Neil Brown <neilb@xxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxx> --- drivers/md/md.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff -puN drivers/md/md.c~md-set-desc_nr-correctly-for-version-1-superblocks drivers/md/md.c --- a/drivers/md/md.c~md-set-desc_nr-correctly-for-version-1-superblocks +++ a/drivers/md/md.c @@ -1064,6 +1064,11 @@ static int super_1_load(mdk_rdev_t *rdev if (rdev->sb_size & bmask) rdev-> sb_size = (rdev->sb_size | bmask)+1; + if (sb->level == cpu_to_le32(LEVEL_MULTIPATH)) + rdev->desc_nr = -1; + else + rdev->desc_nr = le32_to_cpu(sb->dev_number); + if (refdev == 0) ret = 1; else { @@ -1173,7 +1178,6 @@ static int super_1_validate(mddev_t *mdd } if (mddev->level != LEVEL_MULTIPATH) { int role; - rdev->desc_nr = le32_to_cpu(sb->dev_number); role = le16_to_cpu(sb->dev_roles[rdev->desc_nr]); switch(role) { case 0xffff: /* spare */ _ Patches currently in -mm which might be from neilb@xxxxxxx are origin.patch generic_file_buffered_write-deadlock-on-vectored-write.patch md-possible-fix-for-unplug-problem.patch md-set-desc_nr-correctly-for-version-1-superblocks.patch md-delay-starting-md-threads-until-array-is-completely-setup.patch md-fix-resync-speed-calculation-for-restarted-resyncs.patch md-fix-a-plug-unplug-race-in-raid5.patch md-fix-some-small-races-in-bitmap-plugging-in-raid5.patch md-fix-usage-of-wrong-variable-in-raid1.patch md-unify-usage-of-symbolic-names-for-perms.patch md-require-cap_sys_admin-for-re-configuring-md-devices-via-sysfs.patch md-fix-will-configure-message-when-interpreting-md=-kernel-parameter.patch md-include-sector-number-in-messages-about-corrected-read-errors.patch md-dm-reduce-stack-usage-with-stacked-block-devices.patch lockdep-annotate-sunrpc-code.patch - To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html