The patch titled
drivers/scsi/sd.c: fix uninitialized variable in handling medium errors
has been removed from the -mm tree. Its filename is
drivers-scsi-sdc-fix-uninitialized-variable-in-handling-medium-errors.patch
This patch was dropped because some other stuff got merged instead, and this patch doesn't seem to make sense any more
------------------------------------------------------
Subject: drivers/scsi/sd.c: fix uninitialized variable in handling medium errors
From: Mark Lord <lkml@xxxxxx>
When scsi_get_sense_info_fld() fails (returns 0), it does NOT update the
value of first_err_block. But sd_rw_intr() merrily continues to use that
variable regardless, possibly making incorrect decisions about retries and
the like.
This patch removes the randomness there, by using the first sector of the
request (SCpnt->request->sector) in such cases, instead of first_err_block.
Signed-off-by: Mark Lord <lkml@xxxxxx>
Cc: James Bottomley <James.Bottomley@xxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---
drivers/scsi/sd.c | 2 ++
1 file changed, 2 insertions(+)
diff -puN drivers/scsi/sd.c~drivers-scsi-sdc-fix-uninitialized-variable-in-handling-medium-errors drivers/scsi/sd.c
--- a/drivers/scsi/sd.c~drivers-scsi-sdc-fix-uninitialized-variable-in-handling-medium-errors
+++ a/drivers/scsi/sd.c
@@ -959,6 +959,8 @@ static void sd_rw_intr(struct scsi_cmnd
default:
break;
}
+ if (!info_valid)
+ error_sector = SCpnt->request->sector;
error_sector &= ~(block_sectors - 1);
good_bytes = (error_sector - SCpnt->request->sector) << 9;
_
Patches currently in -mm which might be from lkml@xxxxxx are
libata_resume_fix.patch
drivers-scsi-sdc-fix-uninitialized-variable-in-handling-medium-errors.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
