The patch titled
gpio-patchset-fixups: static-numpins
has been removed from the -mm tree. Its filename is
chardev-gpio-for-scx200-pc-8736x-add-platforn_device-static-numpins.patch
This patch was dropped because it was folded into chardev-gpio-for-scx200-pc-8736x-add-platforn_device.patch
------------------------------------------------------
Subject: gpio-patchset-fixups: static-numpins
From: Jim Cromie <jim.cromie@xxxxxxxxx>
Theres currently no reason to expose number of pins, so make it static until a
reason presents itself. Also, change name to be less generic.
Signed-off-by: Jim Cromie <jim.cromie@xxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---
drivers/char/scx200_gpio.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff -puN drivers/char/scx200_gpio.c~chardev-gpio-for-scx200-pc-8736x-add-platforn_device-static-numpins drivers/char/scx200_gpio.c
--- a/drivers/char/scx200_gpio.c~chardev-gpio-for-scx200-pc-8736x-add-platforn_device-static-numpins
+++ a/drivers/char/scx200_gpio.c
@@ -119,7 +119,7 @@ static struct file_operations scx200_gpi
};
struct cdev *scx200_devices;
-int num_devs = 32;
+static int num_pins = 32;
static int __init scx200_gpio_init(void)
{
@@ -141,21 +141,21 @@ static int __init scx200_gpio_init(void)
goto undo_platform_device_add;
if (major)
- rc = register_chrdev_region(dev, num_devs, "scx200_gpio");
+ rc = register_chrdev_region(dev, num_pins, "scx200_gpio");
else {
- rc = alloc_chrdev_region(&dev, 0, num_devs, "scx200_gpio");
+ rc = alloc_chrdev_region(&dev, 0, num_pins, "scx200_gpio");
major = MAJOR(dev);
}
if (rc < 0) {
dev_err(&pdev->dev, "SCx200 chrdev_region err: %d\n", rc);
goto undo_platform_device_add;
}
- scx200_devices = kzalloc(num_devs * sizeof(struct cdev), GFP_KERNEL);
+ scx200_devices = kzalloc(num_pins * sizeof(struct cdev), GFP_KERNEL);
if (!scx200_devices) {
rc = -ENOMEM;
goto undo_chrdev_region;
}
- for (i = 0; i < num_devs; i++) {
+ for (i = 0; i < num_pins; i++) {
struct cdev *cdev = &scx200_devices[i];
cdev_init(cdev, &scx200_gpio_fops);
cdev->owner = THIS_MODULE;
@@ -168,7 +168,7 @@ static int __init scx200_gpio_init(void)
return 0; /* succeed */
undo_chrdev_region:
- unregister_chrdev_region(dev, num_devs);
+ unregister_chrdev_region(dev, num_pins);
undo_platform_device_add:
platform_device_put(pdev);
kfree(pdev); /* undo platform_device_alloc */
@@ -178,7 +178,7 @@ undo_platform_device_add:
static void __exit scx200_gpio_cleanup(void)
{
kfree(scx200_devices);
- unregister_chrdev_region(MKDEV(major, 0), num_devs);
+ unregister_chrdev_region(MKDEV(major, 0), num_pins);
platform_device_put(pdev);
platform_device_unregister(pdev);
/* kfree(pdev); */
_
Patches currently in -mm which might be from jim.cromie@xxxxxxxxx are
chardev-gpio-for-scx200-pc-8736x-whitespace.patch
chardev-gpio-for-scx200-pc-8736x-modernize.patch
chardev-gpio-for-scx200-pc-8736x-add-platforn_device.patch
chardev-gpio-for-scx200-pc-8736x-add-platforn_device-static-numpins.patch
chardev-gpio-for-scx200-pc-8736x-add-platforn_device-enomem-on-device_add-failure.patch
chardev-gpio-for-scx200-pc-8736x-add-platforn_device-scx200-init-undo-malloc.patch
chardev-gpio-for-scx200-pc-8736x-device-minor.patch
chardev-gpio-for-scx200-pc-8736x-put-gpio_dump.patch
chardev-gpio-for-scx200-pc-8736x-add-v-command.patch
chardev-gpio-for-scx200-pc-8736x-refactor-scx200_probe.patch
chardev-gpio-for-scx200-pc-8736x-add-gpio-ops.patch
chardev-gpio-for-scx200-pc-8736x-dispatch.patch
chardev-gpio-for-scx200-pc-8736x-add-empty.patch
chardev-gpio-for-scx200-pc-8736x-migrate-file-ops.patch
chardev-gpio-for-scx200-pc-8736x-migrate-gpio_dump.patch
chardev-gpio-for-scx200-pc-8736x-add-new-pc8736x_gpio.patch
chardev-gpio-for-scx200-pc-8736x-add-new-pc8736x_gpio-no-static-init.patch
chardev-gpio-for-scx200-pc-8736x-add-new-pc8736x_gpio-no-weird-comment-placement.patch
chardev-gpio-for-scx200-pc-8736x-add-new-pc8736x_gpio-fixups.patch
chardev-gpio-for-scx200-pc-8736x-add-platform_device.patch
chardev-gpio-for-scx200-pc-8736x-add-platform_device-request-region.patch
chardev-gpio-for-scx200-pc-8736x-add-platform_device-request-region-series.patch
chardev-gpio-for-scx200-pc-8736x-use-dev_dbg.patch
chardev-gpio-for-scx200-pc-8736x-use-dev_dbg-extern-to-header.patch
chardev-gpio-for-scx200-pc-8736x-fix-gpio_current.patch
chardev-gpio-for-scx200-pc-8736x-fix-gpio_current-make-precedence-explicit.patch
chardev-gpio-for-scx200-pc-8736x-replace-spinlocks.patch
chardev-gpio-for-scx200-pc-8736x-replace-spinlocks-fix.patch
chardev-gpio-for-scx200-pc-8736x-replace-spinlocks-include-linux-ioh.patch
chardev-gpio-for-scx200-pc-8736x-display-pin.patch
chardev-gpio-for-scx200-pc-8736x-add-proper.patch
generic-time-add-macro-to-simplify-hide-mask.patch
gtod-add-scx200-hrt-clocksourcediff.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
