The patch titled via-pata-controller-xfer-fixes-tidy has been added to the -mm tree. Its filename is via-pata-controller-xfer-fixes-tidy.patch See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out what to do about this ------------------------------------------------------ Subject: via-pata-controller-xfer-fixes-tidy From: Andrew Morton <akpm@xxxxxxxx> Cc: Matthieu CASTET <castet.matthieu@xxxxxxx> Cc: Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> Cc: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@xxxxxxxxxxxxxx> Cc: Jeff Garzik <jeff@xxxxxxxxxx> Cc: Tejun Heo <htejun@xxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxx> --- drivers/scsi/pata_via.c | 53 ++++++++++++++++++++------------------ 1 file changed, 29 insertions(+), 24 deletions(-) diff -puN drivers/scsi/pata_via.c~via-pata-controller-xfer-fixes-tidy drivers/scsi/pata_via.c --- a/drivers/scsi/pata_via.c~via-pata-controller-xfer-fixes-tidy +++ a/drivers/scsi/pata_via.c @@ -300,7 +300,8 @@ static void via_set_dmamode(struct ata_p * IRQ_NONE or IRQ_HANDLED. */ -static irqreturn_t pata_via_interrupt (int irq, void *dev_instance, struct pt_regs *regs) +static irqreturn_t pata_via_interrupt(int irq, void *dev_instance, + struct pt_regs *regs) { struct ata_host_set *host_set = dev_instance; unsigned int i; @@ -309,40 +310,44 @@ static irqreturn_t pata_via_interrupt (i /* TODO: make _irqsave conditional on x86 PCI IDE legacy mode */ spin_lock_irqsave(&host_set->lock, flags); - for (i = 0; i < host_set->n_ports; i++) { struct ata_port *ap; ap = host_set->ports[i]; - if (ap && - !(ap->flags & ATA_FLAG_DISABLED)) { + if (ap && !(ap->flags & ATA_FLAG_DISABLED)) { struct ata_queued_cmd *qc; qc = ata_qc_from_tag(ap, ap->active_tag); - if (qc && (!(qc->tf.flags & ATA_TFLAG_POLLING)) && - (qc->flags & ATA_QCFLAG_ACTIVE)) { - if (qc->tf.command == ATA_CMD_SET_FEATURES && - qc->tf.feature == SETFEATURES_XFER) { - /* With some ATAPI devices (CDR-6S48, ...), the - * ata_altstatus take some times (~ 2us) to become not busy. - * Without this quirk, it is impossible to set the xfer - * mode, and the libata-core disable the device. - */ - int i; - for (i = 0; ata_altstatus(ap) & ATA_BUSY; i++) { - if (i > 10) - continue; - udelay(1); - } - - if (i) - ata_port_printk(ap, KERN_WARNING, "ata_altstatus take %dus\n", i); + if (!qc) + continue; + if (qc->tf.flags & ATA_TFLAG_POLLING) + continue; + if (!(qc->flags & ATA_QCFLAG_ACTIVE)) + continue; + if (qc->tf.command == ATA_CMD_SET_FEATURES && + qc->tf.feature == SETFEATURES_XFER) { + /* + * With some ATAPI devices (CDR-6S48, ...), the + * ata_altstatus take some times (~ 2us) to + * become not busy. Without this quirk, it is + * impossible to set the xfer mode, and the + * libata-core disable the device. + */ + int i; + + for (i = 0; ata_altstatus(ap) & ATA_BUSY; i++) { + if (i > 10) + continue; + udelay(1); } - handled |= ata_host_intr(ap, qc); + + if (i) + ata_port_printk(ap, KERN_WARNING, + "ata_altstatus take %dus\n", i); } + handled |= ata_host_intr(ap, qc); } } - spin_unlock_irqrestore(&host_set->lock, flags); return IRQ_RETVAL(handled); _ Patches currently in -mm which might be from akpm@xxxxxxxx are origin.patch disable-debugging-version-of-write_lock.patch acpi-update-asus_acpi-driver-registration-fix.patch catch-notification-of-memory-add-event-of-acpi-via-container-driver-register-start-func-for-memory-device.patch catch-notification-of-memory-add-event-of-acpi-via-container-driveravoid-redundant-call-add_memory.patch cpu_relax-use-in-acpi-lock-fix.patch acpi-asus-s3-resume-fix-fix.patch remove-for_each_cpu.patch more-for_each_cpu-removal.patch sony_apci-resume.patch git-agpgart.patch kauditd_thread-warning-fix.patch git-cifs.patch cifs-build-fix.patch git-dvb.patch tea575x-tuner-build-fix.patch git-dvb-versus-matroxfb.patch git-dvb-printk-warning-fix.patch i2c-801-64bit-resource-fix.patch git-gfs2.patch gfs2-get_sb_dev-fix.patch git-input.patch git-kbuild.patch git-kbuild-revert-kbuild-ignore-makes-built-in-rules-variables.patch revert-sparc-build-breakage.patch git-klibc.patch git-klibc-fixup.patch git-hdrcleanup-vs-git-klibc-on-ia64.patch git-hdrcleanup-vs-git-klibc-on-ia64-2.patch git-hdrinstall-fixup.patch libata-reduce-timeouts.patch libatah-needs-scatterlisth.patch sata-is-bust-on-s390.patch via-pata-controller-xfer-fixes-tidy.patch forcedeth-typecast-cleanup.patch s2io-driver-irq-fix-tidy.patch qla3xxx-is-bust.patch ieee80211-needs-wireless_ext.patch atm-mpcc-warning-fix.patch git-pcmcia-fixup.patch powerpc-kcofnig-warning-fix.patch serial-8250-sysrq-deadlock-fix.patch revert-gregkh-pci-pci-test-that-drivers-properly-call-pci_set_master.patch 64-bit-resources-lose-some-ifdefs.patch clear-abnormal-poweroff-flag-on-via-southbridges-fix-resume-fix.patch areca-raid-linux-scsi-driver.patch git-scsi-target-fixup.patch usb-move-linux-usb_input.h-to-linux-usb-input-fix.patch ipaqc-timing-parameters-fix.patch git-supertrak-fixup.patch revert-x86_64-mm-twofish-cipher---x86_64-assembler.patch revert-x86_64-mm-twofish-cipher---i586-assembler.patch revert-x86_64-mm-twofish-cipher---priority-fix.patch revert-x86_64-mm-twofish-cipher---split-out-common-c-code.patch x86_64-mm-moving-phys_proc_id-and-cpu_core_id-to-cpuinfo_x86-warning-fix.patch pgdat-allocation-for-new-node-add-export-kswapd-start-func-fix.patch adix-tree-rcu-lockless-readside-update-tidy.patch zoned-vm-counters-create-vmstatc-h-from-page_allocc-h-s390-fix.patch zoned-vm-counters-create-vmstatc-h-from-page_allocc-h-fix.patch zoned-vm-counters-basic-zvc-zoned-vm-counter-implementation-tidy.patch zoned-vm-counters-convert-nr_mapped-to-per-zone-counter-fix.patch zoned-vm-counters-remove-nr_file_mapped-from-scan-control-structure-fix.patch zoned-vm-counters-conversion-of-nr_slab-to-per-zone-counter-fix.patch zoned-vm-counters-conversion-of-nr_pagetables-to-per-zone-counter-fix.patch zoned-vm-counters-conversion-of-nr_dirty-to-per-zone-counter-fix.patch zoned-vm-counters-conversion-of-nr_writeback-to-per-zone-counter.patch zoned-vm-counters-conversion-of-nr_writeback-to-per-zone-counter-fix.patch zoned-vm-counters-conversion-of-nr_unstable-to-per-zone-counter-nfs-fix.patch zoned-vm-counters-conversion-of-nr_unstable-to-per-zone-counter-fix.patch zoned-vm-counters-conversion-of-nr_bounce-to-per-zone-counter.patch zoned-vm-counters-conversion-of-nr_bounce-to-per-zone-counter-fix.patch zoned-vm-counters-remove-read_page_state.patch acx1xx-wireless-driver.patch tiacx-pci-build-fix.patch tiacx-ia64-fix.patch i386-moving-phys_proc_id-and-cpu_core_id-to-cpuinfo_x86-warning-fix.patch cpu_relax-smpbootc-fix.patch vdso-randomize-the-i386-vdso-by-moving-it-into-a-vma-tidy.patch vdso-randomize-the-i386-vdso-by-moving-it-into-a-vma-arch_vma_name-fix.patch vdso-randomize-the-i386-vdso-by-moving-it-into-a-vma-vs-x86_64-mm-reliable-stack-trace-support-i386.patch vdso-randomize-the-i386-vdso-by-moving-it-into-a-vma-vs-x86_64-mm-reliable-stack-trace-support-i386-2.patch vdso-randomize-the-i386-vdso-by-moving-it-into-a-vma-vs-x86_64-mm-reliable-stack-trace-support-i386-2-revert-maxmem-change.patch rewritten-backlight-infrastructure-for-portable-apple-computers-fix.patch deprecate-smbfs-in-favour-of-cifs.patch ufs-printk-warning-fixes.patch msnd-section-fix.patch openpromfs-factorize-out-tidy.patch add-driver-for-arm-amba-pl031-rtc-fix.patch add-export_unused_symbol-and-export_unused_symbol_gpl-default.patch kernel-sysc-cleanups-fix.patch cpqarray-section-fix.patch pdflush-handle-resume-wakeups.patch schedule_on_each_cpu-reduce-kmalloc-size.patch load_module-cleanup.patch ax88796-parallel-port-driver-build-fix.patch for_each_cpu_mask-warning-fix.patch add-max6902-rtc-support-tidy.patch add-v3020-rtc-support-tidy.patch at91rm9200-rtc-driver-tidy.patch rtc-add-rtc-ds1553-driver-tidy.patch rtc-add-rtc-ds1553-driver-fix.patch rtc-add-rtc-ds1742-driver-tidy.patch rtc-add-rtc-ds1742-driver-fix.patch readahead-backoff-on-i-o-error-tweaks.patch cyclades-cleanup-cleanup.patch fuse-add-control-filesystem-get_sb_single-fix.patch fuse-add-control-filesystem-printk-fix.patch kthread-update-loopc-to-use-kthread-fix.patch kthread-convert-smbiod-tidy.patch kthread-convert-stop_machine-into-a-kthread.patch fix-bounds-check-in-vsnprintf-to-allow-for-a-0-size-and-tidy.patch irda-usb-printk-fix.patch add-receive_room-flow-control-to-flush_to_ldisc-tidy.patch reiserfs-on-demand-bitmap-loading-fix.patch per-task-delay-accounting-proc-export-of-aggregated-block-i-o-delays-warning-fix.patch add-via-hw-rng-driver-fix.patch add-bcm43xx-hw-rng-support-locking-update.patch hangcheck-remove-monotomic_clock-on-x86.patch sched-fix-smt-nice-lock-contention-and-optimization-tidy.patch swap_prefetch-vs-zoned-counters.patch pi-futex-rt-mutex-tester-fix.patch rtmutex-propagate-priority-settings-into-pi-lock-chains-fix.patch mark-address_space_operations-const-vs-ecryptfs-mmap-operations.patch ecryptfs-alpha-build-fix.patch ecryptfs-more-elegant-aes-key-size-manipulation-tidy.patch ecryptfs-get_sb_dev-fix.patch namespaces-add-nsproxy-dont-include-compileh.patch namespaces-utsname-switch-to-using-uts-namespaces-alpha-fix.patch namespaces-utsname-use-init_utsname-when-appropriate-cifs-update.patch namespaces-utsname-implement-utsname-namespaces-export.patch namespaces-utsname-implement-utsname-namespaces-dont-include-compileh.patch namespaces-utsname-sysctl-hack-cleanup-2-fix.patch ipc-namespace-core-fix.patch task-watchers-task-watchers-tidy.patch task-watchers-add-support-for-per-task-watchers-warning-fix.patch readahead-sysctl-parameters-fix.patch make-copy_from_user_inatomic-not-zero-the-tail-on-i386-vs-reiser4.patch reiser4-hardirq-include-fix.patch reiser4-run-truncate_inode_pages-in-reiser4_delete_inode.patch reiser4-get_sb_dev-fix.patch reiser4-vs-zoned-allocator.patch hpt3xx-rework-rate-filtering-tidy.patch savagefb-add-state-save-and_restore-hooks-tidy.patch au1100fb-add-power-management-support-tidy.patch vt-binding-add-sysfs-control-to-the-vt-layer-fix.patch lib-add-idr_replace-tidy.patch genirq-rename-desc-handler-to-desc-chip-power-fix.patch genirq-rename-desc-handler-to-desc-chip-ia64-fix.patch genirq-rename-desc-handler-to-desc-chip-ia64-fix-2.patch genirq-rename-desc-handler-to-desc-chip-terminate_irqs-fix.patch genirq-ia64-build-fix.patch - To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html