The patch titled
kdump: cciss driver initialization issue fix
has been added to the -mm tree. Its filename is
kdump-cciss-driver-initialization-issue-fix.patch
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this
------------------------------------------------------
Subject: kdump: cciss driver initialization issue fix
From: Vivek Goyal <vgoyal@xxxxxxxxxx>
o cciss driver initialization fails and hits BUG() if underlying device
was active during the driver initialization. Device might be active
if previous kernel crashed and this kernel is booting after that using
kdump.
kernel BUG at drivers/block/cciss.c:2141!
invalid opcode: 0000 [#1]
last sysfs file: /class/sound/timer/dev
CPU: 0
EIP: 0060:[<c59b9ab1>] Not tainted VLI
EFLAGS: 00010296 (2.6.16-1.2122_FC5kdump #1)
EIP is at sendcmd+0x261/0x29c [cciss]
eax: 00000045 ebx: c3300000 ecx: c36b1cf8 edx: c59bd5c5
esi: 00000000 edi: 00001388 ebp: c3ad1400 esp: c36b1d00
ds: 007b es: 007b ss: 0068
Process modprobe (pid: 687, threadinfo=c36b1000 task=c3760aa0)
Stack: <0>00246dc0 c14aef40 00000012 00000000 c4f00480 00000000 c4f00508
c14aef40
c59b9da0 00000024 00000000 00000000 00000000 00000000 00000000 c1006ece
00000246 c35e2c20 000000d0 c4fddc00 c36b1db0 c3ad1400 c12b2570 c4fddc00
Call Trace:
[<c59b9da0>] cciss_getgeometry+0xa9/0x24a [cciss]
[<c1006ece>] dma_alloc_coherent+0xb1/0xec [<c12b2570>]
setup_IO_APIC+0x23/0xcb5
[<c59bc07e>] cciss_init_one+0x5cd/0x9e7 [cciss] [<c10cdd6b>]
pci_match_device+0x13/0xb3
[<c11284ec>] __driver_attach+0x0/0x8b [<c10cde57>]
pci_device_probe+0x36/0x57
[<c1128439>] driver_probe_device+0x42/0x8b [<c112854f>]
__driver_attach+0x63/0x8b
[<c1127f35>] bus_for_each_dev+0x33/0x55 [<c112839d>]
driver_attach+0x11/0x13
[<c11284ec>] __driver_attach+0x0/0x8b [<c1127c56>]
bus_add_driver+0x64/0xfd [<c10cdfe6>] __pci_register_driver+0x7f/0xa1
[<c1031ab2>] sys_init_module+0x1382/0x1514
[<c11e0316>] do_page_fault+0x17d/0x5db [<c1002be9>] syscall_call+0x7/0xb
Code: 00 8b b8 d4 03 00 00 81 ff 81 01 00 00 7e 0f 56 68 0d d6 9b c5 e8 53 28
66 fb 58 5a eb 0d 8b 42 04 89 0c b8 ff 02 e9 72 fe ff ff <0f> 0b 5d 08 a0 d2
9b c5 e9 65 fe ff ff 83
bd d4 03 00 00 00 7e
o If crash_boot parameter is set, then ignore the completed command messages
sent by device which have not been issued in the context of this kernel.
Signed-off-by: Vivek Goyal <vgoyal@xxxxxxxxxx>
Cc: <mike.miller@xxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---
drivers/block/cciss.c | 7 +++++++
1 file changed, 7 insertions(+)
diff -puN drivers/block/cciss.c~kdump-cciss-driver-initialization-issue-fix drivers/block/cciss.c
--- a/drivers/block/cciss.c~kdump-cciss-driver-initialization-issue-fix
+++ a/drivers/block/cciss.c
@@ -2018,6 +2018,13 @@ static int add_sendcmd_reject(__u8 cmd,
ctlr, complete);
/* not much we can do. */
#ifdef CONFIG_CISS_SCSI_TAPE
+ /* We might get notification of completion of commands
+ * which we never issued in this kernel if this boot is
+ * taking place after previous kernel's crash. Simply
+ * ignore the commands in this case.
+ */
+ if (crash_boot)
+ return 0;
return 1;
}
_
Patches currently in -mm which might be from vgoyal@xxxxxxxxxx are
origin.patch
i2c-801-64bit-resource-fix.patch
64-bit-resources-kconfig-change.patch
64-bit-resources-lose-some-ifdefs.patch
register-hot-added-memory-to-iomem-resource.patch
updated-kdump-documentation.patch
fix-kdump-crash-kernel-boot-memory-reservation-for-numa.patch
introduce-crashboot-kernel-command-line-parameter.patch
kdump-cciss-driver-initialization-issue-fix.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
