The patch titled
m68k: completely initialize hw_regs_t in ide_setup_ports
has been removed from the -mm tree. Its filename is
m68k-completely-initialize-hw_regs_t-in-ide_setup_ports.patch
This patch was dropped because it was merged into mainline or a subsystem tree
------------------------------------------------------
Subject: m68k: completely initialize hw_regs_t in ide_setup_ports
From: Roman Zippel <zippel@xxxxxxxxxxxxxx>
ide_setup_ports does not completely initialize the hw_regs_t structure which
can cause random failures, as the structure is often on the stack. None of
the callers expect a partially initialized structure, i.e. none of them do
any setup of their own before calling ide_setup_ports().
Signed-off-by: Roman Zippel <zippel@xxxxxxxxxxxxxx>
Cc: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@xxxxxxxxxxxxxx>
Cc: Alan Cox <alan@xxxxxxxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---
drivers/ide/ide.c | 1 +
drivers/ide/legacy/q40ide.c | 1 +
2 files changed, 2 insertions(+)
diff -puN drivers/ide/ide.c~m68k-completely-initialize-hw_regs_t-in-ide_setup_ports drivers/ide/ide.c
--- a/drivers/ide/ide.c~m68k-completely-initialize-hw_regs_t-in-ide_setup_ports
+++ a/drivers/ide/ide.c
@@ -726,6 +726,7 @@ void ide_setup_ports ( hw_regs_t *hw,
{
int i;
+ memset(hw, 0, sizeof(hw_regs_t));
for (i = 0; i < IDE_NR_PORTS; i++) {
if (offsets[i] == -1) {
switch(i) {
diff -puN drivers/ide/legacy/q40ide.c~m68k-completely-initialize-hw_regs_t-in-ide_setup_ports drivers/ide/legacy/q40ide.c
--- a/drivers/ide/legacy/q40ide.c~m68k-completely-initialize-hw_regs_t-in-ide_setup_ports
+++ a/drivers/ide/legacy/q40ide.c
@@ -80,6 +80,7 @@ void q40_ide_setup_ports ( hw_regs_t *hw
{
int i;
+ memset(hw, 0, sizeof(hw_regs_t));
for (i = 0; i < IDE_NR_PORTS; i++) {
/* BIG FAT WARNING:
assumption: only DATA port is ever used in 16 bit mode */
_
Patches currently in -mm which might be from zippel@xxxxxxxxxxxxxx are
origin.patch
git-kbuild.patch
64-bit-resources-kconfig-change.patch
affs_fill_super-%s-abuses-2.patch
time-use-clocksource-abstraction-for-ntp-adjustments-optimize-out-some-mults-since-gcc-cant-avoid-them.patch
time-rename-clocksource-functions.patch
fix-and-optimize-clock-source-update.patch
fix-rt-mutex-defaults-and-dependencies.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
