The patch titled
dm kcopyd: error accumulation fix
has been added to the -mm tree. Its filename is
dm-kcopyd-error-accumulation-fix.patch
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this
------------------------------------------------------
Subject: dm kcopyd: error accumulation fix
From: Jonathan Brassow <jbrassow@xxxxxxxxxx>
kcopyd should accumulate errors - otherwise I/O failures may be ignored
unintentionally.
And invert 'success' (used in a future patch), using a more intuitive
!(read_err || write_err).
Signed-off-by: Jonathan Brassow <jbrassow@xxxxxxxxxx>
Signed-off-by: Alasdair G Kergon <agk@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---
drivers/md/dm-raid1.c | 2 +-
drivers/md/kcopyd.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff -puN drivers/md/dm-raid1.c~dm-kcopyd-error-accumulation-fix drivers/md/dm-raid1.c
--- a/drivers/md/dm-raid1.c~dm-kcopyd-error-accumulation-fix
+++ a/drivers/md/dm-raid1.c
@@ -602,7 +602,7 @@ static void recovery_complete(int read_e
struct region *reg = (struct region *) context;
/* FIXME: better error handling */
- rh_recovery_end(reg, read_err || write_err);
+ rh_recovery_end(reg, !(read_err || write_err));
}
static int recover(struct mirror_set *ms, struct region *reg)
diff -puN drivers/md/kcopyd.c~dm-kcopyd-error-accumulation-fix drivers/md/kcopyd.c
--- a/drivers/md/kcopyd.c~dm-kcopyd-error-accumulation-fix
+++ a/drivers/md/kcopyd.c
@@ -314,7 +314,7 @@ static void complete_io(unsigned long er
if (error) {
if (job->rw == WRITE)
- job->write_err &= error;
+ job->write_err |= error;
else
job->read_err = 1;
@@ -460,7 +460,7 @@ static void segment_complete(int read_er
job->read_err = 1;
if (write_err)
- job->write_err &= write_err;
+ job->write_err |= write_err;
/*
* Only dispatch more work if there hasn't been an error.
_
Patches currently in -mm which might be from jbrassow@xxxxxxxxxx are
dm-kcopyd-error-accumulation-fix.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
