The patch titled fix synclink_gt diagnostics error reporting has been added to the -mm tree. Its filename is fix-synclink_gt-diagnostics-error-reporting.patch See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out what to do about this ------------------------------------------------------ Subject: fix synclink_gt diagnostics error reporting From: Paul Fulghum <paulkf@xxxxxxxxxxxxx> Fix diagnostics error reporting that was being overwritten by incorrect use of return codes from individual diagnostic functions. Signed-off-by: Paul Fulghum <paulkf@xxxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxx> --- drivers/char/synclink_gt.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff -puN drivers/char/synclink_gt.c~fix-synclink_gt-diagnostics-error-reporting drivers/char/synclink_gt.c --- a/drivers/char/synclink_gt.c~fix-synclink_gt-diagnostics-error-reporting +++ a/drivers/char/synclink_gt.c @@ -4702,13 +4702,13 @@ static int loopback_test(struct slgt_inf static int adapter_test(struct slgt_info *info) { DBGINFO(("testing %s\n", info->device_name)); - if ((info->init_error = register_test(info)) < 0) { + if (register_test(info) < 0) { printk("register test failure %s addr=%08X\n", info->device_name, info->phys_reg_addr); - } else if ((info->init_error = irq_test(info)) < 0) { + } else if (irq_test(info) < 0) { printk("IRQ test failure %s IRQ=%d\n", info->device_name, info->irq_level); - } else if ((info->init_error = loopback_test(info)) < 0) { + } else if (loopback_test(info) < 0) { printk("loopback test failure %s\n", info->device_name); } return info->init_error; _ Patches currently in -mm which might be from paulkf@xxxxxxxxxxxxx are sparse-fixes-for-synclink_cs.patch remove-dead-entry-in-net-wan-kconfig.patch more-tty-cleanups-in-drivers-char.patch fix-memory-leak-in-rocketport-rp_do_receive.patch add-synclink_gt-custom-hdlc-idle.patch add-synclink_gt-crc-return-feature.patch fix-synclink_gt-diagnostics-error-reporting.patch revert-tty-buffering-comment-out-debug-code.patch - To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html