The patch titled I-Force joystick: remove some pointless casts has been added to the -mm tree. Its filename is i-force-joystick-remove-some-pointless-casts.patch See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out what to do about this ------------------------------------------------------ Subject: I-Force joystick: remove some pointless casts From: Jesper Juhl <jesper.juhl@xxxxxxxxx> The 'private' member of struct input_dev is a void*, so no need to cast it when assigning it to a struct iforce* variable. Signed-off-by: Jesper Juhl <jesper.juhl@xxxxxxxxx> Cc: Anssi Hannula <anssi.hannula@xxxxxxxxx> Cc: Dmitry Torokhov <dtor_core@xxxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxx> --- drivers/input/joystick/iforce/iforce-main.c | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) diff -puN drivers/input/joystick/iforce/iforce-main.c~i-force-joystick-remove-some-pointless-casts drivers/input/joystick/iforce/iforce-main.c --- 25/drivers/input/joystick/iforce/iforce-main.c~i-force-joystick-remove-some-pointless-casts Mon Jun 19 16:46:59 2006 +++ 25-akpm/drivers/input/joystick/iforce/iforce-main.c Mon Jun 19 16:46:59 2006 @@ -84,7 +84,7 @@ static struct iforce_device iforce_devic static int iforce_playback(struct input_dev *dev, int effect_id, int value) { - struct iforce* iforce = (struct iforce*)(dev->private); + struct iforce* iforce = dev->private; if (value > 0) { set_bit(FF_CORE_SHOULD_PLAY, iforce->core_effects[effect_id].flags); } @@ -98,7 +98,7 @@ static int iforce_playback(struct input_ static void iforce_set_gain(struct input_dev *dev, u16 gain) { - struct iforce* iforce = (struct iforce*)(dev->private); + struct iforce* iforce = dev->private; unsigned char data[3]; data[0] = gain >> 9; iforce_send_packet(iforce, FF_CMD_GAIN, data); @@ -106,7 +106,7 @@ static void iforce_set_gain(struct input static void iforce_set_autocenter(struct input_dev *dev, u16 magnitude) { - struct iforce* iforce = (struct iforce*)(dev->private); + struct iforce* iforce = dev->private; unsigned char data[3]; data[0] = 0x03; data[1] = magnitude >> 9; @@ -123,7 +123,7 @@ static void iforce_set_autocenter(struct */ static int iforce_upload_effect(struct input_dev *dev, struct ff_effect *effect, struct ff_effect *old) { - struct iforce* iforce = (struct iforce*)(dev->private); + struct iforce* iforce = dev->private; int ret; if (!old) { @@ -171,7 +171,7 @@ static int iforce_upload_effect(struct i */ static int iforce_erase_effect(struct input_dev *dev, int effect_id) { - struct iforce* iforce = (struct iforce*)(dev->private); + struct iforce* iforce = dev->private; int err = 0; struct iforce_core_effect* core_effect; _ Patches currently in -mm which might be from jesper.juhl@xxxxxxxxx are git-alsa.patch git-infiniband.patch git-mtd.patch small-whitespace-cleanup-for-qlogic-driver.patch add-scsi_add_host-failure-handling-for-nsp32.patch xtensa-remove-verify_area-macros.patch xtensa-remove-verify_area-macros-fix.patch oss-cs46xx-cleanup-and-tiny-bugfix.patch i4l-memory-leak-fix-for-sc_ioctl.patch isdn-unsafe-interaction-between-isdn_write-and-isdn_writebuf_stub.patch isdn-unsafe-interaction-between-isdn_write-and-isdn_writebuf_stub-fix.patch binfmt_elf-codingstyle-cleanup-and-remove-some-pointless-casts.patch binfnt_elf-remove-more-casts.patch ensure-null-deref-cant-possibly-happen-in-is_exported.patch bluetooth-fix-potential-null-ptr-deref-in-dtl1_cscdtl1_hci_send_frame.patch pnp-card_probe-fix-memory-leak.patch moxa-remove-pointless-casts.patch moxa-remove-pointless-check-of-tty-argument-vs-null.patch moxa-partial-codingstyle-cleanup-spelling-fixes.patch correct-sak-description-in-sysrqtxt.patch i-force-joystick-remove-some-pointless-casts.patch debug-shared-irqs.patch remove-redundant-null-checks-before-free-in-fs.patch remove-redundant-null-checks-before-free-in-kernel.patch remove-redundant-null-checks-before-free-in-drivers.patch - To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html