- git-kbuild-modpost-parsing-fix.patch removed from -mm tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The patch titled

     git-kbuild: modpost parsing fix

has been removed from the -mm tree.  Its filename is

     git-kbuild-modpost-parsing-fix.patch

This patch was dropped because it needs work

------------------------------------------------------
Subject: git-kbuild: modpost parsing fix
From: Zan Lynx <zlynx@xxxxxxx>


I was getting segmentation faults in modpost while building out of tree
modules.  I'm pretty sure the code should look like the following patch. 
Otherwise, it makes modname look like "vmlinux\tEXPORT_SYMBOL" which then
fails badly later on.

Cc: Sam Ravnborg <sam@xxxxxxxxxxxx>
Cc: Roman Zippel <zippel@xxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---

 scripts/mod/modpost.c |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff -puN scripts/mod/modpost.c~git-kbuild-modpost-parsing-fix scripts/mod/modpost.c
--- a/scripts/mod/modpost.c~git-kbuild-modpost-parsing-fix
+++ a/scripts/mod/modpost.c
@@ -1290,8 +1290,10 @@ static void read_dump(const char *fname,
 			goto fail;
 		*modname++ = '\0';
 		if ((export = strchr(modname, '\t')) != NULL)
-			*export++ = '\0';
-
+			goto fail;
+		*export++ = '\0';
+		if (strchr(export, '\t') != NULL)
+			goto fail;
 		crc = strtoul(line, &d, 16);
 		if (*symname == '\0' || *modname == '\0' || *d != '\0')
 			goto fail;
_

Patches currently in -mm which might be from zlynx@xxxxxxx are

git-kbuild-modpost-parsing-fix.patch

-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel Newbies FAQ]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Photo]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux