+ r3964-fix-gfp_kernel-allocations-in-timer-function.patch added to -mm tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The patch titled

     R3964: rix GFP_KERNEL allocations in timer function

has been added to the -mm tree.  Its filename is

     r3964-fix-gfp_kernel-allocations-in-timer-function.patch

See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this

------------------------------------------------------
Subject: R3964: rix GFP_KERNEL allocations in timer function
From: David Woodhouse <dwmw2@xxxxxxxxxxxxx>


In the error case, add_msg() gets called from timer functions, so should
be using GFP_ATOMIC instead of GFP_KERNEL.

Ref: http://bugzilla.kernel.org/show_bug.cgi?id=6659.  Thanks to Christian
Werner <chw@xxxxxxxxxxxx> for reporting, and for the initial fix.

Signed-off-by: David Woodhouse <dwmw2@xxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---

 drivers/char/n_r3964.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletion(-)

diff -puN drivers/char/n_r3964.c~r3964-fix-gfp_kernel-allocations-in-timer-function drivers/char/n_r3964.c
--- 25/drivers/char/n_r3964.c~r3964-fix-gfp_kernel-allocations-in-timer-function	Fri Jun  9 15:30:49 2006
+++ 25-akpm/drivers/char/n_r3964.c	Fri Jun  9 15:30:49 2006
@@ -951,7 +951,8 @@ static void add_msg(struct r3964_client_
    {
 queue_the_message:
 
-      pMsg = kmalloc(sizeof(struct r3964_message), GFP_KERNEL);
+      pMsg = kmalloc(sizeof(struct r3964_message),
+		     error_code?GFP_ATOMIC:GFP_KERNEL);
       TRACE_M("add_msg - kmalloc %p",pMsg);
       if(pMsg==NULL) {
          return;
_

Patches currently in -mm which might be from dwmw2@xxxxxxxxxxxxx are

git-gfs2.patch
git-hdrcleanup.patch
git-hdrcleanup-vs-git-klibc-on-ia64.patch
git-hdrcleanup-vs-git-klibc-on-ia64-2.patch
git-hdrinstall.patch
git-mtd.patch
git-rbtree.patch
add-page_mkwrite-vm_operations-method.patch
drivers-char-applicomc-proper-module_initexit.patch
r3964-fix-gfp_kernel-allocations-in-timer-function.patch
use-list_add_tail-instead-of-list_add.patch
debug-shared-irqs.patch

-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel Newbies FAQ]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Photo]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux