The patch titled
9pfs: missing result check in v9fs_vfs_readlink() and v9fs_vfs_link()
has been added to the -mm tree. Its filename is
9pfs-missing-result-check-in-v9fs_vfs_readlink-and-v9fs_vfs_link.patch
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this
------------------------------------------------------
Subject: 9pfs: missing result check in v9fs_vfs_readlink() and v9fs_vfs_link()
From: Florin Malita <fmalita@xxxxxxxxx>
__getname() may fail and return NULL (as pointed out by Coverity 437 &
1220).
Signed-off-by: Florin Malita <fmalita@xxxxxxxxx>
Cc: Eric Van Hensbergen <ericvh@xxxxxxxxxxxxxxx>
Cc: <rminnich@xxxxxxxx>
Cc: Latchesar Ionkov <lucho@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---
fs/9p/vfs_inode.c | 6 ++++++
1 file changed, 6 insertions(+)
diff -puN fs/9p/vfs_inode.c~9pfs-missing-result-check-in-v9fs_vfs_readlink-and-v9fs_vfs_link fs/9p/vfs_inode.c
--- devel/fs/9p/vfs_inode.c~9pfs-missing-result-check-in-v9fs_vfs_readlink-and-v9fs_vfs_link 2006-06-08 00:24:50.000000000 -0700
+++ devel-akpm/fs/9p/vfs_inode.c 2006-06-08 00:24:50.000000000 -0700
@@ -1054,6 +1054,9 @@ static int v9fs_vfs_readlink(struct dent
int ret;
char *link = __getname();
+ if (unlikely(!link))
+ return -ENOMEM;
+
if (buflen > PATH_MAX)
buflen = PATH_MAX;
@@ -1227,6 +1230,9 @@ v9fs_vfs_link(struct dentry *old_dentry,
}
name = __getname();
+ if (unlikely(!name))
+ return -ENOMEM;
+
sprintf(name, "%d\n", oldfid->fid);
retval = v9fs_vfs_mkspecial(dir, dentry, V9FS_DMLINK, name);
__putname(name);
_
Patches currently in -mm which might be from fmalita@xxxxxxxxx are
git-mtd.patch
git-netdev-all.patch
git-pcmcia.patch
9pfs-missing-result-check-in-v9fs_vfs_readlink-and-v9fs_vfs_link.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
