The patch titled swapless-pm-add-r-w-migration-entries fix has been added to the -mm tree. Its filename is swapless-pm-add-r-w-migration-entries-fix.patch See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out what to do about this ------------------------------------------------------ Subject: swapless-pm-add-r-w-migration-entries fix From: Hugh Dickins <hugh@xxxxxxxxxxx> Remove unnecessary obfuscation from sys_swapon's range check on swap type, which blew up causing memory corruption once swapless migration made MAX_SWAPFILES no longer 2 ^ MAX_SWAPFILES_SHIFT. Signed-off-by: Hugh Dickins <hugh@xxxxxxxxxxx> Acked-by: Martin Schwidefsky <schwidefsky@xxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxx> --- mm/swapfile.c | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff -puN mm/swapfile.c~swapless-pm-add-r-w-migration-entries-fix mm/swapfile.c --- devel/mm/swapfile.c~swapless-pm-add-r-w-migration-entries-fix 2006-06-06 13:23:49.000000000 -0700 +++ devel-akpm/mm/swapfile.c 2006-06-06 13:23:49.000000000 -0700 @@ -1403,19 +1403,7 @@ asmlinkage long sys_swapon(const char __ if (!(p->flags & SWP_USED)) break; error = -EPERM; - /* - * Test if adding another swap device is possible. There are - * two limiting factors: 1) the number of bits for the swap - * type swp_entry_t definition and 2) the number of bits for - * the swap type in the swap ptes as defined by the different - * architectures. To honor both limitations a swap entry - * with swap offset 0 and swap type ~0UL is created, encoded - * to a swap pte, decoded to a swp_entry_t again and finally - * the swap type part is extracted. This will mask all bits - * from the initial ~0UL that can't be encoded in either the - * swp_entry_t or the architecture definition of a swap pte. - */ - if (type > swp_type(pte_to_swp_entry(swp_entry_to_pte(swp_entry(~0UL,0))))) { + if (type >= MAX_SWAPFILES) { spin_unlock(&swap_lock); goto out; } _ Patches currently in -mm which might be from hugh@xxxxxxxxxxx are mm-vm_bug_on.patch page-migration-make-do_swap_page-redo-the-fault.patch migration-remove-unnecessary-pageswapcache-checks.patch swapless-pm-add-r-w-migration-entries.patch swapless-pm-add-r-w-migration-entries-fix.patch add-page_mkwrite-vm_operations-method.patch mm-remove-vm_locked-before-remap_pfn_range-and-drop-vm_shm.patch swapoff-atomic_inc_not_zero-on-mm_users.patch remove-unused-o_flags-from-do_shmat.patch fix-update_mmu_cache-in-fremapc.patch fix-update_mmu_cache-in-fremapc-fix.patch page-migration-simplify-migrate_pages.patch page-migration-simplify-migrate_pages-tweaks.patch page-migration-handle-freeing-of-pages-in-migrate_pages.patch page-migration-use-allocator-function-for-migrate_pages.patch page-migration-support-moving-of-individual-pages.patch page-migration-detailed-status-for-moving-of-individual-pages.patch page-migration-support-moving-of-individual-pages-fixes.patch page-migration-support-a-vma-migration-function.patch allow-migration-of-mlocked-pages.patch - To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html