The patch titled sbp2: fix check of return value of hpsb_allocate_and_register_addrspace() has been the -mm tree. Its filename is sbp2-fix-check-of-return-value-of.patch This patch was dropped because it was merged into mainline or a subsystem tree ------------------------------------------------------ Subject: sbp2: fix check of return value of hpsb_allocate_and_register_addrspace() From: Stefan Richter <stefanr@xxxxxxxxxxxxxxxxx> I added a failure check in patch "sbp2: variable status FIFO address (fix login timeout)" --- alas for a wrong error value. This is a bug since Linux 2.6.16. Leads to NULL pointer dereference if the call failed, and bogus failure handling if call succeeded. Signed-off-by: Stefan Richter <stefanr@xxxxxxxxxxxxxxxxx> Cc: <stable@xxxxxxxxxx> Cc: Ben Collins <bcollins@xxxxxxxxxx> Cc: Jody McIntyre <scjody@xxxxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxx> --- drivers/ieee1394/sbp2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN drivers/ieee1394/sbp2.c~sbp2-fix-check-of-return-value-of drivers/ieee1394/sbp2.c --- devel/drivers/ieee1394/sbp2.c~sbp2-fix-check-of-return-value-of 2006-06-04 02:51:15.000000000 -0700 +++ devel-akpm/drivers/ieee1394/sbp2.c 2006-06-04 02:51:15.000000000 -0700 @@ -845,7 +845,7 @@ static struct scsi_id_instance_data *sbp &sbp2_highlevel, ud->ne->host, &sbp2_ops, sizeof(struct sbp2_status_block), sizeof(quadlet_t), 0x010000000000ULL, CSR1212_ALL_SPACE_END); - if (!scsi_id->status_fifo_addr) { + if (scsi_id->status_fifo_addr == ~0ULL) { SBP2_ERR("failed to allocate status FIFO address range"); goto failed_alloc; } _ Patches currently in -mm which might be from stefanr@xxxxxxxxxxxxxxxxx are ieee1394-ohci1394c-function-calls-without.patch ieee1394-sbp2-make-tsb42aa9-workaround-specific.patch ieee1394-raw1394-fix-whitespace-after-x86_64.patch ieee1394-ieee1394-ohci1394-cycletoolong.patch ieee1394-ieee1394-support-for-slow-links-or-slow.patch ieee1394-ieee1394-save-ram-by-using-a-single.patch ieee1394-sbp2-remove-manipulation-of-inquiry.patch ieee1394-sbp2-log-number-of-supported-concurrent.patch ieee1394-ieee1394-extend-lowlevel-api-for.patch ieee1394-ohci1394-set-address-range-properties.patch ieee1394-ohci1394-make-phys_dma-parameter.patch ieee1394-sbp2-sbp2-remove-ohci1394-specific.patch ieee1394-sbp2-fix-s800-transfers-if-phys_dma-is.patch ieee1394-update-feature-removal-of-obsolete.patch ieee1394-sbp2-provide-helptext-for.patch ieee1394-sbp2-kconfig-fix.patch ieee1394-sbp2-use-__attribute__packed-for.patch ieee1394-speed-up-of-dma_region_sync_for_cpu.patch ieee1394-sbp2-fix-deregistration-of-status-fifo-address-space.patch ieee1394-add-preprocessor-constant-for-invalid-csr.patch ieee1394_core-switch-to-kthread-api.patch eth1394-endian-fixes.patch - To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html