- nmclan_cs-dereferencing-skb-after-netif_rx.patch removed from -mm tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The patch titled

     nmclan_cs: dereferencing skb after netif_rx()

has been  the -mm tree.  Its filename is

     nmclan_cs-dereferencing-skb-after-netif_rx.patch

This patch was dropped because it was merged upstream

------------------------------------------------------
Subject: nmclan_cs: dereferencing skb after netif_rx()
From: Florin Malita <fmalita@xxxxxxxxx>


The skb may be gone after netif_rx(), we can't use 'skb->len' to update the
stats.  'pkt_len' should work instead.

Coverity CID: 911.

Signed-off-by: Florin Malita <fmalita@xxxxxxxxx>
Cc: Dominik Brodowski <linux@xxxxxxxxxxxxxxxxxxxx>
Acked-by: Jeff Garzik <jeff@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---

 drivers/net/pcmcia/nmclan_cs.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN drivers/net/pcmcia/nmclan_cs.c~nmclan_cs-dereferencing-skb-after-netif_rx drivers/net/pcmcia/nmclan_cs.c
--- devel/drivers/net/pcmcia/nmclan_cs.c~nmclan_cs-dereferencing-skb-after-netif_rx	2006-06-04 02:51:15.000000000 -0700
+++ devel-akpm/drivers/net/pcmcia/nmclan_cs.c	2006-06-04 02:51:15.000000000 -0700
@@ -1204,7 +1204,7 @@ static int mace_rx(struct net_device *de
 
 	dev->last_rx = jiffies;
 	lp->linux_stats.rx_packets++;
-	lp->linux_stats.rx_bytes += skb->len;
+	lp->linux_stats.rx_bytes += pkt_len;
 	outb(0xFF, ioaddr + AM2150_RCV_NEXT); /* skip to next frame */
 	continue;
       } else {
_

Patches currently in -mm which might be from fmalita@xxxxxxxxx are

nmclan_cs-dereferencing-skb-after-netif_rx.patch
git-mtd.patch
git-netdev-all.patch
irda-missing-allocation-result-check-in-irlap_change_speed.patch
pppoe-missing-result-check-in-__pppoe_xmit.patch
git-pcmcia.patch
git-wireless.patch

-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel Newbies FAQ]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Photo]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux