The patch titled
pppoe: missing result check in __pppoe_xmit()
has been added to the -mm tree. Its filename is
pppoe-missing-result-check-in-__pppoe_xmit.patch
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this
------------------------------------------------------
Subject: pppoe: missing result check in __pppoe_xmit()
From: Florin Malita <fmalita@xxxxxxxxx>
skb_clone() may fail, we should check the result.
Coverity CID: 1215.
Signed-off-by: Florin Malita <fmalita@xxxxxxxxx>
Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
Cc: <mostrows@xxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---
drivers/net/pppoe.c | 3 +++
1 file changed, 3 insertions(+)
diff -puN drivers/net/pppoe.c~pppoe-missing-result-check-in-__pppoe_xmit drivers/net/pppoe.c
--- devel/drivers/net/pppoe.c~pppoe-missing-result-check-in-__pppoe_xmit 2006-05-31 11:15:07.000000000 -0700
+++ devel-akpm/drivers/net/pppoe.c 2006-05-31 11:15:07.000000000 -0700
@@ -861,6 +861,9 @@ static int __pppoe_xmit(struct sock *sk,
* give dev_queue_xmit something it can free.
*/
skb2 = skb_clone(skb, GFP_ATOMIC);
+
+ if (skb2 == NULL)
+ goto abort;
}
ph = (struct pppoe_hdr *) skb_push(skb2, sizeof(struct pppoe_hdr));
_
Patches currently in -mm which might be from fmalita@xxxxxxxxx are
origin.patch
nmclan_cs-dereferencing-skb-after-netif_rx.patch
git-mtd.patch
git-netdev-all.patch
irda-missing-allocation-result-check-in-irlap_change_speed.patch
pppoe-missing-result-check-in-__pppoe_xmit.patch
git-pcmcia.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
