The patch titled
use-list_add_tail-instead-of-list_add fix
has been removed from the -mm tree. Its filename is
use-list_add_tail-instead-of-list_add-fix.patch
This patch was probably dropped from -mm because
it has now been merged into a subsystem tree or
into Linus's tree, or because it was folded into
its parent patch in the -mm tree.
------------------------------------------------------
Subject: use-list_add_tail-instead-of-list_add fix
From: Akinobu Mita <mita@xxxxxxxxxxxxxxxx>
I realized that the replacements in isdn, jffs2, and sctp made them less
readable. Because these are trying to insert the list node into right
place, not trying to insert the tail of the list head.
This patch reverts them.
Cc: Karsten Keil <kkeil@xxxxxxx>
Cc: David Woodhouse <dwmw2@xxxxxxxxxxxxx>
Cc: Sridhar Samudrala <sri@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---
drivers/isdn/capi/capi.c | 2 +-
fs/jffs2/compr.c | 4 ++--
net/sctp/outqueue.c | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff -puN drivers/isdn/capi/capi.c~use-list_add_tail-instead-of-list_add-fix drivers/isdn/capi/capi.c
--- devel/drivers/isdn/capi/capi.c~use-list_add_tail-instead-of-list_add-fix 2006-05-17 13:10:01.000000000 -0700
+++ devel-akpm/drivers/isdn/capi/capi.c 2006-05-17 13:10:01.000000000 -0700
@@ -238,7 +238,7 @@ static struct capiminor *capiminor_alloc
if (minor < capi_ttyminors) {
mp->minor = minor;
- list_add_tail(&mp->list, &p->list);
+ list_add(&mp->list, p->list.prev);
}
}
write_unlock_irqrestore(&capiminor_list_lock, flags);
diff -puN fs/jffs2/compr.c~use-list_add_tail-instead-of-list_add-fix fs/jffs2/compr.c
--- devel/fs/jffs2/compr.c~use-list_add_tail-instead-of-list_add-fix 2006-05-17 13:10:01.000000000 -0700
+++ devel-akpm/fs/jffs2/compr.c 2006-05-17 13:10:01.000000000 -0700
@@ -231,7 +231,7 @@ int jffs2_register_compressor(struct jff
list_for_each_entry(this, &jffs2_compressor_list, list) {
if (this->priority < comp->priority) {
- list_add_tail(&comp->list, &this->list);
+ list_add(&comp->list, this->list.prev);
goto out;
}
}
@@ -394,7 +394,7 @@ reinsert:
list_del(&comp->list);
list_for_each_entry(this, &jffs2_compressor_list, list) {
if (this->priority < comp->priority) {
- list_add_tail(&comp->list, &this->list);
+ list_add(&comp->list, this->list.prev);
spin_unlock(&jffs2_compressor_list_lock);
return 0;
}
diff -puN net/sctp/outqueue.c~use-list_add_tail-instead-of-list_add-fix net/sctp/outqueue.c
--- devel/net/sctp/outqueue.c~use-list_add_tail-instead-of-list_add-fix 2006-05-17 13:10:01.000000000 -0700
+++ devel-akpm/net/sctp/outqueue.c 2006-05-17 13:10:01.000000000 -0700
@@ -370,7 +370,7 @@ static void sctp_insert_list(struct list
lchunk = list_entry(pos, struct sctp_chunk, transmitted_list);
ltsn = ntohl(lchunk->subh.data_hdr->tsn);
if (TSN_lt(ntsn, ltsn)) {
- list_add_tail(new, pos);
+ list_add(new, pos->prev);
done = 1;
break;
}
_
Patches currently in -mm which might be from mita@xxxxxxxxxxxxxxxx are
git-block.patch
use-list_add_tail-instead-of-list_add.patch
arch-use-list_move.patch
core-use-list_move.patch
net-rxrpc-use-list_move.patch
drivers-use-list_move.patch
fs-use-list_move.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
