The patch titled page migration: Update comments has been removed from the -mm tree. Its filename is more-page-migration-use-migration-entries-for-file-pages-update-comments-8.patch This patch was probably dropped from -mm because it has now been merged into a subsystem tree or into Linus's tree, or because it was folded into its parent patch in the -mm tree. ------------------------------------------------------ Subject: page migration: Update comments From: Christoph Lameter <clameter@xxxxxxx> Edit comments to be nicer better and reflect the current state of page migration. Remove useless BUG_ON() in migrate_entry_wait() since migration_entry_to_page() already does a BUG_ON(). Signed-off-by: Christoph Lameter <clameter@xxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxx> --- vm/page_migration | 0 mm/migrate.c | 17 +++++++++-------- linux/swap.h | 0 3 files changed, 9 insertions(+), 8 deletions(-) diff -puN Documentation/vm/page_migration~more-page-migration-use-migration-entries-for-file-pages-update-comments-8 Documentation/vm/page_migration diff -puN include/linux/swap.h~more-page-migration-use-migration-entries-for-file-pages-update-comments-8 include/linux/swap.h diff -puN mm/migrate.c~more-page-migration-use-migration-entries-for-file-pages-update-comments-8 mm/migrate.c --- devel/mm/migrate.c~more-page-migration-use-migration-entries-for-file-pages-update-comments-8 2006-05-11 15:18:47.000000000 -0700 +++ devel-akpm/mm/migrate.c 2006-05-11 15:18:47.000000000 -0700 @@ -460,19 +460,20 @@ int buffer_migrate_page(struct address_s } EXPORT_SYMBOL(buffer_migrate_page); +/* + * Default handling if a filesystem does not provide a migration function. + */ static int fallback_migrate_page(struct address_space *mapping, struct page *newpage, struct page *page) { - /* - * Default handling if a filesystem does not provide - * a migration function. We can only migrate clean - * pages so try to write out any dirty pages first. - */ if (PageDirty(page)) { /* - * Remove the migration entries because pageout() may - * unlock which may result in migration entries pointing - * to unlocked pages. + * A dirty page may imply that the underlying filesystem has + * the page on some queue. So the page must be clean for + * migration. Writeout may mean we loose the lock and the + * page state is no longer what we checked for earlier. + * At this point we know that the migration attempt cannot + * be successful. */ remove_migration_ptes(page, page); _ Patches currently in -mm which might be from clameter@xxxxxxx are page-migration-make-do_swap_page-redo-the-fault.patch slab-extract-cache_free_alien-from-__cache_free.patch migration-remove-unnecessary-pageswapcache-checks.patch page-migration-cleanup-rename-ignrefs-to-migration.patch page-migration-cleanup-group-functions.patch page-migration-cleanup-remove-useless-definitions.patch page-migration-cleanup-drop-nr_refs-in-remove_references.patch page-migration-cleanup-extract-try_to_unmap-from-migration-functions.patch page-migration-cleanup-pass-mapping-to-migration-functions.patch page-migration-cleanup-move-fallback-handling-into-special-function.patch swapless-pm-add-r-w-migration-entries.patch swapless-pm-add-r-w-migration-entries-fix-2.patch swapless-page-migration-rip-out-swap-based-logic.patch swapless-page-migration-modify-core-logic.patch more-page-migration-do-not-inc-dec-rss-counters.patch more-page-migration-use-migration-entries-for-file-pages.patch page-migration-update-documentation.patch mm-remove-vm_locked-before-remap_pfn_range-and-drop-vm_shm.patch page-migration-simplify-migrate_pages.patch page-migration-simplify-migrate_pages-tweaks.patch page-migration-handle-freeing-of-pages-in-migrate_pages.patch page-migration-use-allocator-function-for-migrate_pages.patch page-migration-support-moving-of-individual-pages.patch page-migration-detailed-status-for-moving-of-individual-pages.patch page-migration-support-moving-of-individual-pages-fixes.patch page-migration-support-moving-of-individual-pages-x86_64-support.patch page-migration-support-moving-of-individual-pages-x86-support.patch page-migration-support-a-vma-migration-function.patch allow-migration-of-mlocked-pages.patch cpuset-remove-extra-cpuset_zone_allowed-check-in-__alloc_pages.patch - To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html