The patch titled
readahead: debug radix tree new functions
has been removed from the -mm tree. Its filename is
readahead-debug-radix-tree-new-functions.patch
This patch was probably dropped from -mm because
it has now been merged into a subsystem tree or
into Linus's tree, or because it was folded into
its parent patch in the -mm tree.
------------------------------------------------------
Subject: readahead: debug radix tree new functions
From: Wu Fengguang <wfg@xxxxxxxxxxxxxxxx>
Do some sanity checkings on the newly added radix tree code.
Signed-off-by: Wu Fengguang <wfg@xxxxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---
mm/readahead.c | 24 ++++++++++++++++++++++++
1 files changed, 24 insertions(+)
diff -puN mm/readahead.c~readahead-debug-radix-tree-new-functions mm/readahead.c
--- 25/mm/readahead.c~readahead-debug-radix-tree-new-functions Wed May 24 16:50:58 2006
+++ 25-akpm/mm/readahead.c Wed May 24 16:50:58 2006
@@ -63,6 +63,8 @@ enum ra_class {
RA_CLASS_COUNT
};
+#define DEBUG_READAHEAD_RADIXTREE
+
/* Read-ahead events to be accounted. */
enum ra_event {
RA_EVENT_CACHE_MISS, /* read cache misses */
@@ -1314,6 +1316,16 @@ static pgoff_t find_segtail(struct addre
cond_resched();
read_lock_irq(&mapping->tree_lock);
ra_index = radix_tree_scan_hole(&mapping->page_tree, index, max_scan);
+#ifdef DEBUG_READAHEAD_RADIXTREE
+ BUG_ON(!__find_page(mapping, index));
+ WARN_ON(ra_index < index);
+ if (ra_index != index && !__find_page(mapping, ra_index - 1))
+ printk(KERN_ERR "radix_tree_scan_hole(index=%lu ra_index=%lu "
+ "max_scan=%lu nrpages=%lu) fooled!\n",
+ index, ra_index, max_scan, mapping->nrpages);
+ if (ra_index != ~0UL && ra_index - index < max_scan)
+ WARN_ON(__find_page(mapping, ra_index));
+#endif
read_unlock_irq(&mapping->tree_lock);
if (ra_index <= index + max_scan)
@@ -1406,6 +1418,13 @@ static unsigned long query_page_cache_se
read_lock_irq(&mapping->tree_lock);
index = radix_tree_scan_hole_backward(&mapping->page_tree,
offset, ra_max);
+#ifdef DEBUG_READAHEAD_RADIXTREE
+ WARN_ON(index > offset);
+ if (index != offset)
+ WARN_ON(!__find_page(mapping, index + 1));
+ if (index && offset - index < ra_max)
+ WARN_ON(__find_page(mapping, index));
+#endif
read_unlock_irq(&mapping->tree_lock);
*remain = offset - index;
@@ -1441,6 +1460,11 @@ static unsigned long query_page_cache_se
struct radix_tree_node *node;
node = radix_tree_cache_lookup_parent(&mapping->page_tree,
&cache, offset - count, 1);
+#ifdef DEBUG_READAHEAD_RADIXTREE
+ if (node != radix_tree_lookup_parent(&mapping->page_tree,
+ offset - count, 1))
+ BUG();
+#endif
if (!node)
break;
}
_
Patches currently in -mm which might be from wfg@xxxxxxxxxxxxxxxx are
readahead-debug-radix-tree-new-functions.patch
readahead-debug-traces-showing-accessed-file-names.patch
readahead-debug-traces-showing-read-patterns.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
