The patch titled
PCMCIA: missing pcmcia_get_socket() result check
has been added to the -mm tree. Its filename is
pcmcia-missing-pcmcia_get_socket-result-check.patch
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this
------------------------------------------------------
Subject: PCMCIA: missing pcmcia_get_socket() result check
From: Florin Malita <fmalita@xxxxxxxxx>
The result of pcmcia_get_socket() may be NULL but ds_event() uses it
without checking.
Coverity CID: 436.
Signed-off-by: Florin Malita <fmalita@xxxxxxxxx>
Cc: Dominik Brodowski <linux@xxxxxxxxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---
drivers/pcmcia/ds.c | 6 ++++++
1 files changed, 6 insertions(+)
diff -puN drivers/pcmcia/ds.c~pcmcia-missing-pcmcia_get_socket-result-check drivers/pcmcia/ds.c
--- devel/drivers/pcmcia/ds.c~pcmcia-missing-pcmcia_get_socket-result-check 2006-05-24 18:26:28.000000000 -0700
+++ devel-akpm/drivers/pcmcia/ds.c 2006-05-24 18:26:28.000000000 -0700
@@ -1143,6 +1143,12 @@ static int ds_event(struct pcmcia_socket
{
struct pcmcia_socket *s = pcmcia_get_socket(skt);
+ if (!s) {
+ printk(KERN_ERR "PCMCIA obtaining reference to socket %p " \
+ "failed, event 0x%x lost!\n", skt, event);
+ return -ENODEV;
+ }
+
ds_dbg(1, "ds_event(0x%06x, %d, 0x%p)\n",
event, priority, skt);
_
Patches currently in -mm which might be from fmalita@xxxxxxxxx are
origin.patch
affs-possible-null-pointer-dereference-in-affs_rename.patch
git-mtd.patch
git-netdev-all.patch
irda-missing-allocation-result-check-in-irlap_change_speed.patch
pcmcia-missing-pcmcia_get_socket-result-check.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
