The patch titled moxa: remove pointless check of 'tty' argument vs NULL has been added to the -mm tree. Its filename is moxa-remove-pointless-check-of-tty-argument-vs-null.patch See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out what to do about this ------------------------------------------------------ Subject: moxa: remove pointless check of 'tty' argument vs NULL From: Jesper Juhl <jesper.juhl@xxxxxxxxx> Remove pointless check of 'tty' argument vs NULL from moxa driver. Signed-off-by: Jesper Juhl <jesper.juhl@xxxxxxxxx> Cc: Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxx> --- drivers/char/mxser.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff -puN drivers/char/mxser.c~moxa-remove-pointless-check-of-tty-argument-vs-null drivers/char/mxser.c --- devel/drivers/char/mxser.c~moxa-remove-pointless-check-of-tty-argument-vs-null 2006-05-22 17:01:18.000000000 -0700 +++ devel-akpm/drivers/char/mxser.c 2006-05-22 17:01:18.000000000 -0700 @@ -1081,7 +1081,7 @@ static int mxser_write(struct tty_struct struct mxser_struct *info = tty->driver_data; unsigned long flags; - if (!tty || !info->xmit_buf) + if (!info->xmit_buf) return (0); while (1) { @@ -1117,7 +1117,7 @@ static void mxser_put_char(struct tty_st struct mxser_struct *info = tty->driver_data; unsigned long flags; - if (!tty || !info->xmit_buf) + if (!info->xmit_buf) return; if (info->xmit_cnt >= SERIAL_XMIT_SIZE - 1) _ Patches currently in -mm which might be from jesper.juhl@xxxxxxxxx are origin.patch fix-mem-leak-in-sidewinder-driver.patch git-mtd.patch small-whitespace-cleanup-for-qlogic-driver.patch add-scsi_add_host-failure-handling-for-nsp32.patch oss-cs46xx-cleanup-and-tiny-bugfix.patch i4l-memory-leak-fix-for-sc_ioctl.patch isdn-unsafe-interaction-between-isdn_write-and-isdn_writebuf_stub.patch isdn-unsafe-interaction-between-isdn_write-and-isdn_writebuf_stub-fix.patch binfmt_elf-codingstyle-cleanup-and-remove-some-pointless-casts.patch binfnt_elf-remove-more-casts.patch ensure-null-deref-cant-possibly-happen-in-is_exported.patch bluetooth-fix-potential-null-ptr-deref-in-dtl1_cscdtl1_hci_send_frame.patch pnp-card_probe-fix-memory-leak.patch fix-unlikely-memory-leak-in-dac960-driver.patch moxa-remove-pointless-casts.patch moxa-remove-pointless-check-of-tty-argument-vs-null.patch debug-shared-irqs.patch remove-redundant-null-checks-before-free-in-fs.patch remove-redundant-null-checks-before-free-in-kernel.patch remove-redundant-null-checks-before-free-in-drivers.patch - To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html