The patch titled
kbuild: fix modpost segfault for 64bit mipsel kernel
has been removed from the -mm tree. Its filename is
kbuild-fix-modpost-segfault-for-64bit-mipsel-kernel.patch
This patch was probably dropped from -mm because
it has now been merged into a subsystem tree or
into Linus's tree, or because it was folded into
its parent patch in the -mm tree.
------------------------------------------------------
Subject: kbuild: fix modpost segfault for 64bit mipsel kernel
From: Atsushi Nemoto <anemo@xxxxxxxxxxxxx>
Here is an updated r_info layout fix. Please apply "check SHT_REL
sections" patch before this.
64bit mips has different r_info layout. This patch fixes modpost
segfault for 64bit little endian mips kernel.
Signed-off-by: Atsushi Nemoto <anemo@xxxxxxxxxxxxx>
Cc: Sam Ravnborg <sam@xxxxxxxxxxxx>
Cc: Ralf Baechle <ralf@xxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---
scripts/mod/modpost.c | 31 +++++++++++++++++++++++++++----
scripts/mod/modpost.h | 21 +++++++++++++++++++--
2 files changed, 46 insertions(+), 6 deletions(-)
diff -puN scripts/mod/modpost.c~kbuild-fix-modpost-segfault-for-64bit-mipsel-kernel scripts/mod/modpost.c
--- devel/scripts/mod/modpost.c~kbuild-fix-modpost-segfault-for-64bit-mipsel-kernel 2006-05-20 14:59:40.000000000 -0700
+++ devel-akpm/scripts/mod/modpost.c 2006-05-20 14:59:40.000000000 -0700
@@ -700,6 +700,7 @@ static void check_sec_ref(struct module
const char *name = secstrings + sechdrs[i].sh_name;
const char *secname;
Elf_Rela r;
+ unsigned int r_sym;
/* We want to process only relocation sections and not .init */
if (sechdrs[i].sh_type == SHT_RELA) {
Elf_Rela *rela;
@@ -711,9 +712,20 @@ static void check_sec_ref(struct module
for (rela = start; rela < stop; rela++) {
r.r_offset = TO_NATIVE(rela->r_offset);
- r.r_info = TO_NATIVE(rela->r_info);
+#if KERNEL_ELFCLASS == ELFCLASS64
+ if (hdr->e_machine == EM_MIPS) {
+ r_sym = ELF64_MIPS_R_SYM(rela->r_info);
+ r_sym = TO_NATIVE(r_sym);
+ } else {
+ r.r_info = TO_NATIVE(rela->r_info);
+ r_sym = ELF_R_SYM(r.r_info);
+ }
+#else
+ r.r_info = TO_NATIVE(rela->r_info);
+ r_sym = ELF_R_SYM(r.r_info);
+#endif
r.r_addend = TO_NATIVE(rela->r_addend);
- sym = elf->symtab_start + ELF_R_SYM(r.r_info);
+ sym = elf->symtab_start + r_sym;
/* Skip special sections */
if (sym->st_shndx >= SHN_LORESERVE)
continue;
@@ -734,9 +746,20 @@ static void check_sec_ref(struct module
for (rel = start; rel < stop; rel++) {
r.r_offset = TO_NATIVE(rel->r_offset);
- r.r_info = TO_NATIVE(rel->r_info);
+#if KERNEL_ELFCLASS == ELFCLASS64
+ if (hdr->e_machine == EM_MIPS) {
+ r_sym = ELF64_MIPS_R_SYM(rel->r_info);
+ r_sym = TO_NATIVE(r_sym);
+ } else {
+ r.r_info = TO_NATIVE(rel->r_info);
+ r_sym = ELF_R_SYM(r.r_info);
+ }
+#else
+ r.r_info = TO_NATIVE(rel->r_info);
+ r_sym = ELF_R_SYM(r.r_info);
+#endif
r.r_addend = 0;
- sym = elf->symtab_start + ELF_R_SYM(r.r_info);
+ sym = elf->symtab_start + r_sym;
/* Skip special sections */
if (sym->st_shndx >= SHN_LORESERVE)
continue;
diff -puN scripts/mod/modpost.h~kbuild-fix-modpost-segfault-for-64bit-mipsel-kernel scripts/mod/modpost.h
--- devel/scripts/mod/modpost.h~kbuild-fix-modpost-segfault-for-64bit-mipsel-kernel 2006-05-20 14:59:40.000000000 -0700
+++ devel-akpm/scripts/mod/modpost.h 2006-05-20 14:59:40.000000000 -0700
@@ -41,6 +41,25 @@
#define ELF_R_TYPE ELF64_R_TYPE
#endif
+/* The 64-bit MIPS ELF ABI uses an unusual reloc format. */
+typedef struct
+{
+ Elf32_Word r_sym; /* Symbol index */
+ unsigned char r_ssym; /* Special symbol for 2nd relocation */
+ unsigned char r_type3; /* 3rd relocation type */
+ unsigned char r_type2; /* 2nd relocation type */
+ unsigned char r_type1; /* 1st relocation type */
+} _Elf64_Mips_R_Info;
+
+typedef union
+{
+ Elf64_Xword r_info_number;
+ _Elf64_Mips_R_Info r_info_fields;
+} _Elf64_Mips_R_Info_union;
+
+#define ELF64_MIPS_R_SYM(i) \
+ ((__extension__ (_Elf64_Mips_R_Info_union)(i)).r_info_fields.r_sym)
+
#if KERNEL_ELFDATA != HOST_ELFDATA
static inline void __endian(const void *src, void *dest, unsigned int size)
@@ -50,8 +69,6 @@ static inline void __endian(const void *
((unsigned char*)dest)[i] = ((unsigned char*)src)[size - i-1];
}
-
-
#define TO_NATIVE(x) \
({ \
typeof(x) __x; \
_
Patches currently in -mm which might be from anemo@xxxxxxxxxxxxx are
origin.patch
git-cryptodev.patch
fix-broken-vm86-interrupt-signal-handling.patch
rtc-rtc-dev-uie-emulation.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
