The patch titled
SPARSEMEM incorrectly calculates section number
has been removed from the -mm tree. Its filename is
sparsemem-incorrectly-calculates-section-number.patch
This patch was probably dropped from -mm because
it has now been merged into a subsystem tree or
into Linus's tree, or because it was folded into
its parent patch in the -mm tree.
------------------------------------------------------
Subject: SPARSEMEM incorrectly calculates section number
From: Mike Kravetz <kravetz@xxxxxxxxxx>
A bad calculation/loop in __section_nr() could result in incorrect section
information being put into sysfs memory entries. This primarily impacts
memory add operations as the sysfs information is used while onlining new
memory.
Fix suggested by Dave Hansen.
Note that the bug may not be obvious from the patch. It actually occurs in
the function's return statement:
return (root_nr * SECTIONS_PER_ROOT) + (ms - root);
In the existing code, root_nr has already been multiplied by
SECTIONS_PER_ROOT.
Signed-off-by: Mike Kravetz <kravetz@xxxxxxxxxx>
Cc: Dave Hansen <haveblue@xxxxxxxxxx>
Cc: Andy Whitcroft <apw@xxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---
mm/sparse.c | 7 ++-----
1 files changed, 2 insertions(+), 5 deletions(-)
diff -puN mm/sparse.c~sparsemem-incorrectly-calculates-section-number mm/sparse.c
--- devel/mm/sparse.c~sparsemem-incorrectly-calculates-section-number 2006-05-20 14:59:35.000000000 -0700
+++ devel-akpm/mm/sparse.c 2006-05-20 14:59:35.000000000 -0700
@@ -87,11 +87,8 @@ int __section_nr(struct mem_section* ms)
unsigned long root_nr;
struct mem_section* root;
- for (root_nr = 0;
- root_nr < NR_MEM_SECTIONS;
- root_nr += SECTIONS_PER_ROOT) {
- root = __nr_to_section(root_nr);
-
+ for (root_nr = 0; root_nr < NR_SECTION_ROOTS; root_nr++) {
+ root = __nr_to_section(root_nr * SECTIONS_PER_ROOT);
if (!root)
continue;
_
Patches currently in -mm which might be from kravetz@xxxxxxxxxx are
origin.patch
sparsemem-record-nid-during-memory-present.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
