The patch titled
page migration: handle freeing of pages in migrate_pages()
has been added to the -mm tree. Its filename is
page-migration-handle-freeing-of-pages-in-migrate_pages.patch
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this
------------------------------------------------------
Subject: page migration: handle freeing of pages in migrate_pages()
From: Christoph Lameter <clameter@xxxxxxx>
Do not leave pages on the lists passed to migrate_pages(). Seems that we will
not need any postprocessing of pages. This will simplify the handling of
pages by the callers of migrate_pages().
Signed-off-by: Christoph Lameter <clameter@xxxxxxx>
Cc: Hugh Dickins <hugh@xxxxxxxxxxx>
Cc: Jes Sorensen <jes@xxxxxxxxxxxxxxxxxx>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx>
Cc: Lee Schermerhorn <lee.schermerhorn@xxxxxx>
Cc: Andi Kleen <ak@xxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---
include/linux/migrate.h | 7 ++---
mm/mempolicy.c | 8 ------
mm/migrate.c | 48 ++++++++++++++++++--------------------
3 files changed, 27 insertions(+), 36 deletions(-)
diff -puN include/linux/migrate.h~page-migration-handle-freeing-of-pages-in-migrate_pages include/linux/migrate.h
--- 25/include/linux/migrate.h~page-migration-handle-freeing-of-pages-in-migrate_pages Fri May 19 12:28:12 2006
+++ 25-akpm/include/linux/migrate.h Fri May 19 12:28:12 2006
@@ -8,8 +8,7 @@ extern int isolate_lru_page(struct page
extern int putback_lru_pages(struct list_head *l);
extern int migrate_page(struct address_space *,
struct page *, struct page *);
-extern int migrate_pages(struct list_head *l, struct list_head *t,
- struct list_head *moved, struct list_head *failed);
+extern int migrate_pages(struct list_head *l, struct list_head *t);
extern int migrate_pages_to(struct list_head *pagelist,
struct vm_area_struct *vma, int dest);
extern int fail_migrate_page(struct address_space *,
@@ -22,8 +21,8 @@ extern int migrate_prep(void);
static inline int isolate_lru_page(struct page *p, struct list_head *list)
{ return -ENOSYS; }
static inline int putback_lru_pages(struct list_head *l) { return 0; }
-static inline int migrate_pages(struct list_head *l, struct list_head *t,
- struct list_head *moved, struct list_head *failed) { return -ENOSYS; }
+static inline int migrate_pages(struct list_head *l, struct list_head *t)
+ { return -ENOSYS; }
static inline int migrate_pages_to(struct list_head *pagelist,
struct vm_area_struct *vma, int dest) { return 0; }
diff -puN mm/mempolicy.c~page-migration-handle-freeing-of-pages-in-migrate_pages mm/mempolicy.c
--- 25/mm/mempolicy.c~page-migration-handle-freeing-of-pages-in-migrate_pages Fri May 19 12:28:12 2006
+++ 25-akpm/mm/mempolicy.c Fri May 19 12:28:12 2006
@@ -603,11 +603,8 @@ int migrate_to_node(struct mm_struct *mm
check_range(mm, mm->mmap->vm_start, TASK_SIZE, &nmask,
flags | MPOL_MF_DISCONTIG_OK, &pagelist);
- if (!list_empty(&pagelist)) {
+ if (!list_empty(&pagelist))
err = migrate_pages_to(&pagelist, NULL, dest);
- if (!list_empty(&pagelist))
- putback_lru_pages(&pagelist);
- }
return err;
}
@@ -773,9 +770,6 @@ long do_mbind(unsigned long start, unsig
err = -EIO;
}
- if (!list_empty(&pagelist))
- putback_lru_pages(&pagelist);
-
up_write(&mm->mmap_sem);
mpol_free(new);
return err;
diff -puN mm/migrate.c~page-migration-handle-freeing-of-pages-in-migrate_pages mm/migrate.c
--- 25/mm/migrate.c~page-migration-handle-freeing-of-pages-in-migrate_pages Fri May 19 12:28:12 2006
+++ 25-akpm/mm/migrate.c Fri May 19 12:28:12 2006
@@ -624,6 +624,15 @@ unlock:
unlock_page(page);
ret:
if (rc != -EAGAIN) {
+ /*
+ * A page that has been migrated has all references
+ * removed and will be freed. A page that has not been
+ * migrated will have kepts its references and be
+ * restored.
+ */
+ list_del(&page->lru);
+ move_to_lru(page);
+
list_del(&newpage->lru);
move_to_lru(newpage);
}
@@ -640,12 +649,12 @@ ret:
*
* The function returns after 10 attempts or if no pages
* are movable anymore because to has become empty
- * or no retryable pages exist anymore.
+ * or no retryable pages exist anymore. All pages will be
+ * retruned to the LRU or freed.
*
- * Return: Number of pages not migrated when "to" ran empty.
+ * Return: Number of pages not migrated.
*/
-int migrate_pages(struct list_head *from, struct list_head *to,
- struct list_head *moved, struct list_head *failed)
+int migrate_pages(struct list_head *from, struct list_head *to)
{
int retry = 1;
int nr_failed = 0;
@@ -675,11 +684,9 @@ int migrate_pages(struct list_head *from
retry++;
break;
case 0:
- list_move(&page->lru, moved);
break;
default:
/* Permanent failure */
- list_move(&page->lru, failed);
nr_failed++;
break;
}
@@ -689,6 +696,7 @@ int migrate_pages(struct list_head *from
if (!swapwrite)
current->flags &= ~PF_SWAPWRITE;
+ putback_lru_pages(from);
return nr_failed + retry;
}
@@ -702,11 +710,10 @@ int migrate_pages_to(struct list_head *p
struct vm_area_struct *vma, int dest)
{
LIST_HEAD(newlist);
- LIST_HEAD(moved);
- LIST_HEAD(failed);
int err = 0;
unsigned long offset = 0;
int nr_pages;
+ int nr_failed = 0;
struct page *page;
struct list_head *p;
@@ -740,26 +747,17 @@ redo:
if (nr_pages > MIGRATE_CHUNK_SIZE)
break;
}
- err = migrate_pages(pagelist, &newlist, &moved, &failed);
+ err = migrate_pages(pagelist, &newlist);
- putback_lru_pages(&moved); /* Call release pages instead ?? */
-
- if (err >= 0 && list_empty(&newlist) && !list_empty(pagelist))
- goto redo;
-out:
- /* Return leftover allocated pages */
- while (!list_empty(&newlist)) {
- page = list_entry(newlist.next, struct page, lru);
- list_del(&page->lru);
- __free_page(page);
+ if (err >= 0) {
+ nr_failed += err;
+ if (list_empty(&newlist) && !list_empty(pagelist))
+ goto redo;
}
- list_splice(&failed, pagelist);
- if (err < 0)
- return err;
+out:
/* Calculate number of leftover pages */
- nr_pages = 0;
list_for_each(p, pagelist)
- nr_pages++;
- return nr_pages;
+ nr_failed++;
+ return nr_failed;
}
_
Patches currently in -mm which might be from clameter@xxxxxxx are
origin.patch
page-migration-make-do_swap_page-redo-the-fault.patch
slab-extract-cache_free_alien-from-__cache_free.patch
migration-remove-unnecessary-pageswapcache-checks.patch
page-migration-cleanup-rename-ignrefs-to-migration.patch
page-migration-cleanup-group-functions.patch
page-migration-cleanup-remove-useless-definitions.patch
page-migration-cleanup-drop-nr_refs-in-remove_references.patch
page-migration-cleanup-extract-try_to_unmap-from-migration-functions.patch
page-migration-cleanup-extract-try_to_unmap-from-migration-functions-update-comments-7.patch
page-migration-cleanup-pass-mapping-to-migration-functions.patch
page-migration-cleanup-move-fallback-handling-into-special-function.patch
page-migration-cleanup-move-fallback-handling-into-special-function-update-comments-9.patch
swapless-pm-add-r-w-migration-entries.patch
swapless-pm-add-r-w-migration-entries-ifdefs.patch
swapless-pm-add-r-w-migration-entries-update-comments.patch
swapless-pm-add-r-w-migration-entries-update-comments-4.patch
swapless-pm-add-r-w-migration-entries-update-comments-6.patch
swapless-page-migration-rip-out-swap-based-logic.patch
swapless-page-migration-modify-core-logic.patch
swapless-page-migration-modify-core-logic-remove-useless-mapping-checks.patch
more-page-migration-do-not-inc-dec-rss-counters.patch
more-page-migration-use-migration-entries-for-file-pages.patch
more-page-migration-use-migration-entries-for-file-pages-fix.patch
more-page-migration-use-migration-entries-for-file-pages-update-comments-5.patch
more-page-migration-use-migration-entries-for-file-pages-update-comments-8.patch
more-page-migration-use-migration-entries-for-file-pages-remove_migration_ptes.patch
more-page-migration-use-migration-entries-for-file-pages-replace-call-to-pageout-with-writepage-2.patch
page-migration-update-documentation.patch
page-migration-simplify-migrate_pages.patch
page-migration-simplify-migrate_pages-tweaks.patch
page-migration-handle-freeing-of-pages-in-migrate_pages.patch
page-migration-use-allocator-function-for-migrate_pages.patch
page-migration-support-moving-of-individual-pages.patch
page-migration-detailed-status-for-moving-of-individual-pages.patch
page-migration-support-a-vma-migration-function.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
