+ kbuild-export-type-enhancement-to-modpostc-fix.patch added to -mm tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The patch titled

     kbuild wierdness with EXPORT_SYMBOL_GPL

has been added to the -mm tree.  Its filename is

     kbuild-export-type-enhancement-to-modpostc-fix.patch

See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this


From: Valdis.Kletnieks@xxxxxx

It looks like a buggy comparison down in the guts of
kbuild-export-type-enhancement-to-modpostc.patch - it's doing something
really odd when it hits a EXPORT_SYMBOL_GPL.

Signed-off-by: Valdis Kletnieks <valdis.kletnieks@xxxxxx>
Cc: Andreas Gruenbacher <agruen@xxxxxxx>
Cc: Ram Pai <linuxram@xxxxxxxxxx>
Cc: Avantika Mathur <mathur@xxxxxxxxxx>
Cc: Sam Ravnborg <sam@xxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---

 scripts/mod/modpost.c |    9 ++++++---
 1 files changed, 6 insertions(+), 3 deletions(-)

diff -puN scripts/mod/modpost.c~kbuild-export-type-enhancement-to-modpostc-fix scripts/mod/modpost.c
--- 25/scripts/mod/modpost.c~kbuild-export-type-enhancement-to-modpostc-fix	Mon May 15 12:12:36 2006
+++ 25-akpm/scripts/mod/modpost.c	Mon May 15 12:13:27 2006
@@ -1142,12 +1142,15 @@ static void read_dump(const char *fname,
 					*d != '\0')
 			goto fail;
 
-		if ((strcmp(export, "EXPORT_SYMBOL_GPL")))
+		if ((strcmp(export, "EXPORT_SYMBOL_GPL") == 0))
 			export_type = 1;
-		else if(strcmp(export, "EXPORT_SYMBOL") == 0)
+		else if (strcmp(export, "EXPORT_SYMBOL") == 0)
 			export_type = 0;
-		else
+		else {
+			warn("Odd symbol export=%s symname=%s modname=%s\n",
+				export, symname, modname);
 			goto fail;
+		}
 
 		if (!(mod = find_module(modname))) {
 			if (is_vmlinux(modname)) {
_

Patches currently in -mm which might be from valdis.kletnieks@xxxxxx are

kbuild-export-type-enhancement-to-modpostc-fix.patch

-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel Newbies FAQ]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Photo]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux