The patch titled
Remove silly messages from input layer
has been added to the -mm tree. Its filename is
remove-silly-messages-from-input-layer.patch
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this
From: Dave Jones <davej@xxxxxxxxxx>
There are two messages in the input layer that seem to be triggerable very
easily, and they confuse end-users to no end. "too many keys pressed?
Should I press less keys?" I actually got a complaint from one user that he
had only hit one key before being told to type less.
The latter message seems to trigger with certain keyboard switchers and
again, does nothing but confuse people.
Best of all, asides from the silly messages, none of the people suffering
them report any other misbehaviour, their keyboards work just fine.
Signed-off-by: Dave Jones <davej@xxxxxxxxxx>
Cc: Dmitry Torokhov <dtor_core@xxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---
drivers/input/keyboard/atkbd.c | 7 +------
1 files changed, 1 insertion(+), 6 deletions(-)
diff -puN drivers/input/keyboard/atkbd.c~remove-silly-messages-from-input-layer drivers/input/keyboard/atkbd.c
--- devel/drivers/input/keyboard/atkbd.c~remove-silly-messages-from-input-layer 2006-05-13 08:29:31.000000000 -0700
+++ devel-akpm/drivers/input/keyboard/atkbd.c 2006-05-13 08:29:31.000000000 -0700
@@ -340,7 +340,6 @@ static irqreturn_t atkbd_interrupt(struc
atkbd_report_key(atkbd->dev, regs, KEY_HANJA, 3);
goto out;
case ATKBD_RET_ERR:
- printk(KERN_DEBUG "atkbd.c: Keyboard on %s reports too many keys pressed.\n", serio->phys);
goto out;
}
@@ -359,11 +358,7 @@ static irqreturn_t atkbd_interrupt(struc
case ATKBD_KEY_NULL:
break;
case ATKBD_KEY_UNKNOWN:
- if (data == ATKBD_RET_ACK || data == ATKBD_RET_NAK) {
- printk(KERN_WARNING "atkbd.c: Spurious %s on %s. Some program, "
- "like XFree86, might be trying access hardware directly.\n",
- data == ATKBD_RET_ACK ? "ACK" : "NAK", serio->phys);
- } else {
+ if (data != ATKBD_RET_ACK && data != ATKBD_RET_NAK) {
printk(KERN_WARNING "atkbd.c: Unknown key %s "
"(%s set %d, code %#x on %s).\n",
atkbd->release ? "released" : "pressed",
_
Patches currently in -mm which might be from davej@xxxxxxxxxx are
git-acpi.patch
git-agpgart.patch
remove-silly-messages-from-input-layer.patch
improve-pci-config-space-writeback.patch
git-watchdog.patch
fix-ide-locking-error.patch
post-halloween-doc.patch
debug-warn-if-we-sleep-in-an-irq-for-a-long-time.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
