The patch titled
Clean up coding style in taskstats interface
has been added to the -mm tree. Its filename is
per-task-delay-accounting-taskstats-interface-fix-1.patch
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this
From: Balbir Singh <balbir@xxxxxxxxxx>
On Mon, May 08, 2006 at 02:31:39PM -0700, Andrew Morton wrote:
> Balbir Singh <balbir@xxxxxxxxxx> wrote:
> >
> > +
> > + if ((rc = genl_register_ops(&family, &taskstats_ops)) < 0)
> > + goto err;
>
> rc = genl_register_ops(&family, &taskstats_ops);
> if (rc < 0)
> goto err;
>
> please.
Sure, here you go Andrew
I have updated the coding style as per your suggestion
Balbir Singh,
Linux Technology Center,
IBM Software Labs
Changelog
1. Split the complex if condition into
a. function call
b. check return status for error
Signed-off-by: Balbir Singh <balbir@xxxxxxxxxx>
Signed-off-by: Shailabh Nagar <nagar@xxxxxxxxxxxxxx>
Cc: Jes Sorensen <jes@xxxxxxx>
Cc: Peter Chubb <peterc@xxxxxxxxxxxxxxxxxx>
Cc: Erich Focht <efocht@xxxxxxxxxx>
Cc: Levent Serinol <lserinol@xxxxxxxxx>
Cc: Jay Lan <jlan@xxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---
kernel/taskstats.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletion(-)
diff -puN kernel/taskstats.c~per-task-delay-accounting-taskstats-interface-fix-1 kernel/taskstats.c
--- devel/kernel/taskstats.c~per-task-delay-accounting-taskstats-interface-fix-1 2006-05-11 09:23:59.000000000 -0700
+++ devel-akpm/kernel/taskstats.c 2006-05-11 09:23:59.000000000 -0700
@@ -312,7 +312,8 @@ static int __init taskstats_init(void)
return rc;
family_registered = 1;
- if ((rc = genl_register_ops(&family, &taskstats_ops)) < 0)
+ rc = genl_register_ops(&family, &taskstats_ops);
+ if (rc < 0)
goto err;
return 0;
_
Patches currently in -mm which might be from balbir@xxxxxxxxxx are
fix-dcache-race-during-umount.patch
fix-dcache-race-during-umount-fix.patch
prune_one_dentry-tweaks.patch
per-task-delay-accounting-setup.patch
per-task-delay-accounting-setup-fix-1.patch
per-task-delay-accounting-setup-fix-2.patch
per-task-delay-accounting-sync-block-i-o-and-swapin-delay-collection.patch
per-task-delay-accounting-sync-block-i-o-and-swapin-delay-collection-fix-1.patch
per-task-delay-accounting-cpu-delay-collection-via-schedstats.patch
per-task-delay-accounting-cpu-delay-collection-via-schedstats-fix-1.patch
per-task-delay-accounting-utilities-for-genetlink-usage.patch
per-task-delay-accounting-taskstats-interface.patch
per-task-delay-accounting-taskstats-interface-fix-1.patch
per-task-delay-accounting-delay-accounting-usage-of-taskstats-interface.patch
per-task-delay-accounting-documentation.patch
per-task-delay-accounting-proc-export-of-aggregated-block-i-o-delays.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
