The patch titled
Add comments on units for the delay fields
has been added to the -mm tree. Its filename is
per-task-delay-accounting-sync-block-i-o-and-swapin-delay-collection-fix-1.patch
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this
From: Balbir Singh <balbir@xxxxxxxxxx>
On Mon, May 08, 2006 at 02:19:52PM -0700, Andrew Morton wrote:
> Balbir Singh <balbir@xxxxxxxxxx> wrote:
> >
> > @@ -550,6 +550,12 @@ struct task_delay_info {
> > * Atomicity of updates to XXX_delay, XXX_count protected by
> > * single lock above (split into XXX_lock if contention is an issue).
> > */
> > +
> > + struct timespec blkio_start, blkio_end; /* Shared by blkio, swapin */
> > + u64 blkio_delay; /* wait for sync block io completion */
> > + u64 swapin_delay; /* wait for swapin block io completion */
> > + u32 blkio_count;
> > + u32 swapin_count;
>
> These fields are a bit mystifying.
>
> In what units are blkio_delay and swapin_delay?
>
> What is the meaning behind blkio_count and swapin_count?
>
> Better comments needed, please.
Hi, Andrew,
Here is an update, that adds comments to the fields as suggested in the
review comments
Balbir Singh,
Linux Technology Center,
IBM Software Labs
Changelog
1. Add comments to the task_delay_info structure, documenting the units
of delay and document the meaning of the count fields in the structure.
Signed-off-by: Balbir Singh <balbir@xxxxxxxxxx>
Signed-off-by: Shailabh Nagar <nagar@xxxxxxxxxxxxxx>
Cc: Jes Sorensen <jes@xxxxxxx>
Cc: Peter Chubb <peterc@xxxxxxxxxxxxxxxxxx>
Cc: Erich Focht <efocht@xxxxxxxxxx>
Cc: Levent Serinol <lserinol@xxxxxxxxx>
Cc: Jay Lan <jlan@xxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---
include/linux/sched.h | 11 +++++++++--
1 files changed, 9 insertions(+), 2 deletions(-)
diff -puN include/linux/sched.h~per-task-delay-accounting-sync-block-i-o-and-swapin-delay-collection-fix-1 include/linux/sched.h
--- devel/include/linux/sched.h~per-task-delay-accounting-sync-block-i-o-and-swapin-delay-collection-fix-1 2006-05-11 09:23:51.000000000 -0700
+++ devel-akpm/include/linux/sched.h 2006-05-11 09:23:51.000000000 -0700
@@ -551,11 +551,18 @@ struct task_delay_info {
* single lock above (split into XXX_lock if contention is an issue).
*/
+ /*
+ * XXX_count is incremented on every XXX operation, the delay
+ * associated with the operation is added to XXX_delay.
+ * XXX_delay contains the accumulated delay time in nanoseconds.
+ */
struct timespec blkio_start, blkio_end; /* Shared by blkio, swapin */
u64 blkio_delay; /* wait for sync block io completion */
u64 swapin_delay; /* wait for swapin block io completion */
- u32 blkio_count;
- u32 swapin_count;
+ u32 blkio_count; /* total count of the number of sync block */
+ /* io operations performed */
+ u32 swapin_count; /* total count of the number of swapin block */
+ /* io operations performed */
};
#endif
_
Patches currently in -mm which might be from balbir@xxxxxxxxxx are
fix-dcache-race-during-umount.patch
fix-dcache-race-during-umount-fix.patch
prune_one_dentry-tweaks.patch
per-task-delay-accounting-setup.patch
per-task-delay-accounting-setup-fix-1.patch
per-task-delay-accounting-setup-fix-2.patch
per-task-delay-accounting-sync-block-i-o-and-swapin-delay-collection.patch
per-task-delay-accounting-sync-block-i-o-and-swapin-delay-collection-fix-1.patch
per-task-delay-accounting-cpu-delay-collection-via-schedstats.patch
per-task-delay-accounting-cpu-delay-collection-via-schedstats-fix-1.patch
per-task-delay-accounting-utilities-for-genetlink-usage.patch
per-task-delay-accounting-taskstats-interface.patch
per-task-delay-accounting-taskstats-interface-fix-1.patch
per-task-delay-accounting-delay-accounting-usage-of-taskstats-interface.patch
per-task-delay-accounting-documentation.patch
per-task-delay-accounting-proc-export-of-aggregated-block-i-o-delays.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
