The patch titled
reverse pci config space restore order
has been added to the -mm tree. Its filename is
reverse-pci-config-space-restore-order.patch
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this
From: "Yu, Luming" <luming.yu@xxxxxxxxx>
According to Intel ICH spec, there are several rules that Base Address
should be programmed before IOSE (PCICMD register ) enabled.
For example ICH7:
12.1.3 SATA : the base address register for the bus
master register should be programmed before this bit is set.
11.1.3: PCICMD (USB): The base address register for
USB should be programmed before this bit is set.
....
To make sure kernel code follow this rule
, and prevent unnecessary confusion. I proposal this
patch.
Signed-off-by: Luming Yu <luming.yu@xxxxxxxxx>
Cc: Greg KH <greg@xxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---
drivers/pci/pci.c | 6 +++++-
1 files changed, 5 insertions(+), 1 deletion(-)
diff -puN drivers/pci/pci.c~reverse-pci-config-space-restore-order drivers/pci/pci.c
--- devel/drivers/pci/pci.c~reverse-pci-config-space-restore-order 2006-04-24 23:59:18.000000000 -0700
+++ devel-akpm/drivers/pci/pci.c 2006-04-25 00:00:29.000000000 -0700
@@ -462,7 +462,11 @@ pci_restore_state(struct pci_dev *dev)
{
int i;
- for (i = 0; i < 16; i++)
+ /*
+ * The Base Address register should be programmed before the command
+ * register(s)
+ */
+ for (i = 15; i >= 0 ; i--)
pci_write_config_dword(dev,i * 4, dev->saved_config_space[i]);
pci_restore_msi_state(dev);
pci_restore_msix_state(dev);
_
Patches currently in -mm which might be from luming.yu@xxxxxxxxx are
git-acpi.patch
fw-memory-leakages-in-driver-acpi-videoc.patch
reverse-pci-config-space-restore-order.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
