- ide-fix-ok_stat.patch removed from -mm tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The patch titled

     ide: fix OK_STAT()

has been removed from the -mm tree.  Its filename is

     ide-fix-ok_stat.patch

This patch was probably dropped from -mm because
it has now been merged into a subsystem tree or
into Linus's tree, or because it was folded into
its parent patch in the -mm tree.


From: Al Boldi <a1426z@xxxxxxxxx>

get rid of this message:

 	hdb: set_drive_speed_status: status=0x40 { DriveReady }
 	ide: failed opcode was: unknown

Mark Lord <liml@xxxxxx> said:

 Assuming hdb is a CDROM/optical drive, then this change makes sense for that.
 But I don't think it is a valid (good) change for regular ATA disks.

 A more complex patch is required, one which correctly handles each drive type.

Cc: Alan Cox <alan@xxxxxxxxxxxxxxxxxxx>
Cc: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@xxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---

 include/linux/ide.h |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -puN include/linux/ide.h~ide-fix-ok_stat include/linux/ide.h
--- devel/include/linux/ide.h~ide-fix-ok_stat	2006-04-23 18:49:08.000000000 -0700
+++ devel-akpm/include/linux/ide.h	2006-04-23 18:49:08.000000000 -0700
@@ -120,7 +120,7 @@ typedef unsigned char	byte;	/* used ever
 #define IDE_BCOUNTL_REG		IDE_LCYL_REG
 #define IDE_BCOUNTH_REG		IDE_HCYL_REG
 
-#define OK_STAT(stat,good,bad)	(((stat)&((good)|(bad)))==(good))
+#define OK_STAT(stat,good,bad)	(((stat)&((good)|(bad)))==((stat)&(good)))
 #define BAD_R_STAT		(BUSY_STAT   | ERR_STAT)
 #define BAD_W_STAT		(BAD_R_STAT  | WRERR_STAT)
 #define BAD_STAT		(BAD_R_STAT  | DRQ_STAT)
_

Patches currently in -mm which might be from a1426z@xxxxxxxxx are

ide-io-increase-timeout-value-to-allow-for-slave-wakeup.patch
ide-fix-ok_stat.patch

-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel Newbies FAQ]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Photo]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux