+ memory-leak-fix-for-whiteheat-driver.patch added to -mm tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The patch titled

     memory leak fix for whiteheat driver

has been added to the -mm tree.  Its filename is

     memory-leak-fix-for-whiteheat-driver.patch

See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this


From: Jesper Juhl <jesper.juhl@xxxxxxxxx>

We may return from drivers/usb/serial/whiteheat.c::whiteheat_attach()
without freeing `result' if we leave via the no_firmware: label.

Spotted by the coverity checker as #670

Signed-off-by: Jesper Juhl <jesper.juhl@xxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---

 drivers/usb/serial/whiteheat.c |    1 +
 1 files changed, 1 insertion(+)

diff -puN drivers/usb/serial/whiteheat.c~memory-leak-fix-for-whiteheat-driver drivers/usb/serial/whiteheat.c
--- devel/drivers/usb/serial/whiteheat.c~memory-leak-fix-for-whiteheat-driver	2006-04-23 16:04:28.000000000 -0700
+++ devel-akpm/drivers/usb/serial/whiteheat.c	2006-04-23 16:04:28.000000000 -0700
@@ -508,6 +508,7 @@ no_firmware:
 	err("%s: Unable to retrieve firmware version, try replugging\n", serial->type->description);
 	err("%s: If the firmware is not running (status led not blinking)\n", serial->type->description);
 	err("%s: please contact support@xxxxxxxxxxxxxxx\n", serial->type->description);
+	kfree(result);
 	return -ENODEV;
 
 no_command_private:
_

Patches currently in -mm which might be from jesper.juhl@xxxxxxxxx are

origin.patch
git-mtd.patch
small-whitespace-cleanup-for-qlogic-driver.patch
memory-leak-fix-for-whiteheat-driver.patch
reduce-nr-of-ptr-derefs-in-fs-jffs2-summaryc.patch
oss-cs46xx-cleanup-and-tiny-bugfix.patch
i4l-memory-leak-fix-for-sc_ioctl.patch
isdn-unsafe-interaction-between-isdn_write-and-isdn_writebuf_stub.patch
binfmt_elf-codingstyle-cleanup-and-remove-some-pointless-casts.patch
debug-shared-irqs.patch
remove-redundant-null-checks-before-free-in-fs.patch
remove-redundant-null-checks-before-free-in-arch.patch
remove-redundant-null-checks-before-free-in-kernel.patch
remove-redundant-null-checks-before-free-in-drivers.patch

-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel Newbies FAQ]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Photo]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux