+ mv643xx_eth-provide-sysfs-class-device-symlink.patch added to -mm tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The patch titled

     mv643xx_eth: provide sysfs class device symlink

has been added to the -mm tree.  Its filename is

     mv643xx_eth-provide-sysfs-class-device-symlink.patch

See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this


From: Olaf Hering <olh@xxxxxxx>

On Sat, Mar 11, Olaf Hering wrote:
> Why is the /sys/class/net/eth0/device symlink not created for the
> mv643xx_eth driver? Does this work for other platform device drivers?
> Seems to work for the ps2 keyboard at least.

The SET_NETDEV_DEV has to be done before a call to register_netdev.  With
the new patch below, the device symlink for the platform device was
created.  Unfortunately, after the 4 ls commands, the network connection
died.  No idea if the box crashed or if something else broke, lost remote
access.

Provide sysfs 'device' in /class/net/ethN Also, set module owner field,
like pcnet32 driver does.

Signed-off-by: Olaf Hering <olh@xxxxxxx>
Cc: Dale Farnsworth <dale@xxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---

 drivers/net/mv643xx_eth.c |    2 ++
 1 files changed, 2 insertions(+)

diff -puN drivers/net/mv643xx_eth.c~mv643xx_eth-provide-sysfs-class-device-symlink drivers/net/mv643xx_eth.c
--- devel/drivers/net/mv643xx_eth.c~mv643xx_eth-provide-sysfs-class-device-symlink	2006-04-22 00:42:15.000000000 -0700
+++ devel-akpm/drivers/net/mv643xx_eth.c	2006-04-22 00:42:15.000000000 -0700
@@ -1419,6 +1419,8 @@ static int mv643xx_eth_probe(struct plat
 	mv643xx_eth_update_pscr(dev, &cmd);
 	mv643xx_set_settings(dev, &cmd);
 
+	SET_MODULE_OWNER(dev);
+	SET_NETDEV_DEV(dev, &pdev->dev);
 	err = register_netdev(dev);
 	if (err)
 		goto out;
_

Patches currently in -mm which might be from olh@xxxxxxx are

mv643xx_eth-provide-sysfs-class-device-symlink.patch
fix-dcache-race-during-umount.patch
fix-dcache-race-during-umount-fix.patch
prune_one_dentry-tweaks.patch

-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel Newbies FAQ]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Photo]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux