The patch titled
tpm: fix ordering bug in error path
has been removed from the -mm tree. Its filename is
tpm-use-clear_bit-fix-fix-fix-fix-fix.patch
This patch was probably dropped from -mm because
it has now been merged into a subsystem tree or
into Linus's tree, or because it was folded into
its parent patch in the -mm tree.
From: Kylene Jo Hall <kjhall@xxxxxxxxxx>
The clear_bit of chip->dev_num ended up after the kfree of chip in the
error path of the tpm_register_hardware function. This patch fixes things
to avoid a potential segmentation fault.
This bug was found by Coverity.
Signed-off-by: Kylene Hall <kjhall@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---
drivers/char/tpm/tpm.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
diff -puN drivers/char/tpm/tpm.c~tpm-use-clear_bit-fix-fix-fix-fix-fix drivers/char/tpm/tpm.c
--- devel/drivers/char/tpm/tpm.c~tpm-use-clear_bit-fix-fix-fix-fix-fix 2006-04-20 00:16:01.000000000 -0700
+++ devel-akpm/drivers/char/tpm/tpm.c 2006-04-20 00:16:01.000000000 -0700
@@ -1139,8 +1139,8 @@ struct tpm_chip *tpm_register_hardware(s
chip->vendor.miscdev.name,
chip->vendor.miscdev.minor);
put_device(dev);
- kfree(chip);
clear_bit(chip->dev_num, dev_mask);
+ kfree(chip);
return NULL;
}
_
Patches currently in -mm which might be from kjhall@xxxxxxxxxx are
tpm-fix-memory-leak.patch
tpm-fix-missing-string.patch
tpm-spacing-cleanups.patch
tpm-reorganize-sysfs-files.patch
tpm-chip-struct-update.patch
tpm-return-chip-from-tpm_register_hardware.patch
tpm-command-duration-update.patch
tpm-new-12-sysfs-files.patch
tpm-driver-for-next-generation-tpm-chips.patch
tpm-msecs_to_jiffies-cleanups.patch
tpm-use-clear_bit.patch
tpm-tpm_infineon-updated-to-latest-interface-changes.patch
tpm-check-mem-start-and-len.patch
tpm-update-bios-log-code-for-12.patch
tpm_infineon-section-fixup.patch
tpm-spacing-cleanups-2.patch
tpm-add-interrupt-module-parameter.patch
tpm-add-hid-module-paramater.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
