The patch titled
invert irq/migration.c brach prediction
has been added to the -mm tree. Its filename is
invert-irq-migrationc-brach-prediction.patch
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this
From: Daniel Walker <dwalker@xxxxxxxxxx>
If you get to that point in the code it means that desc->move_irq is set,
pending_irq_cpumask[irq] and cpu_online_map should have a value. Still
pretty good chance anding those two you'll still have a value. So these
two branch predictors should be inverted.
Signed-off-by: Daniel Walker <dwalker@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---
kernel/irq/migration.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff -puN kernel/irq/migration.c~invert-irq-migrationc-brach-prediction kernel/irq/migration.c
--- devel/kernel/irq/migration.c~invert-irq-migrationc-brach-prediction 2006-04-20 23:31:58.000000000 -0700
+++ devel-akpm/kernel/irq/migration.c 2006-04-20 23:31:58.000000000 -0700
@@ -30,7 +30,7 @@ void move_native_irq(int irq)
desc->move_irq = 0;
- if (likely(cpus_empty(pending_irq_cpumask[irq])))
+ if (unlikely(cpus_empty(pending_irq_cpumask[irq])))
return;
if (!desc->handler->set_affinity)
@@ -49,7 +49,7 @@ void move_native_irq(int irq)
* cause some ioapics to mal-function.
* Being paranoid i guess!
*/
- if (unlikely(!cpus_empty(tmp))) {
+ if (likely(!cpus_empty(tmp))) {
if (likely(!(desc->status & IRQ_DISABLED)))
desc->handler->disable(irq);
_
Patches currently in -mm which might be from dwalker@xxxxxxxxxx are
invert-irq-migrationc-brach-prediction.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
