- m41t00-fix-bitmasks-when-writing-to-chip.patch removed from -mm tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The patch titled

     m41t00: fix bitmasks when writing to chip

has been removed from the -mm tree.  Its filename is

     m41t00-fix-bitmasks-when-writing-to-chip.patch

This patch was probably dropped from -mm because
it has now been merged into a subsystem tree or
into Linus's tree, or because it was folded into
its parent patch in the -mm tree.


From: David Barksdale <amatus@xxxxxxxxxx>

Fix the bitmasks used when writing to the M41T00 registers.  The original
code used a mask of 0x7f when writing to each register, this is incorrect
and probably the result of a copy-paste error.  As a result years from 1980
to 1999 will be read back as 2000 to 2019.

Signed-off-by: David Barksdale <amatus@xxxxxxxxxx>
Acked-by: Jean Delvare <khali@xxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---

 drivers/i2c/chips/m41t00.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff -puN drivers/i2c/chips/m41t00.c~m41t00-fix-bitmasks-when-writing-to-chip drivers/i2c/chips/m41t00.c
--- devel/drivers/i2c/chips/m41t00.c~m41t00-fix-bitmasks-when-writing-to-chip	2006-04-18 22:19:57.000000000 -0700
+++ devel-akpm/drivers/i2c/chips/m41t00.c	2006-04-18 22:19:57.000000000 -0700
@@ -131,13 +131,13 @@ m41t00_set(void *arg)
 	if ((i2c_smbus_write_byte_data(save_client, 0, tm.tm_sec & 0x7f) < 0)
 		|| (i2c_smbus_write_byte_data(save_client, 1, tm.tm_min & 0x7f)
 			< 0)
-		|| (i2c_smbus_write_byte_data(save_client, 2, tm.tm_hour & 0x7f)
+		|| (i2c_smbus_write_byte_data(save_client, 2, tm.tm_hour & 0x3f)
 			< 0)
-		|| (i2c_smbus_write_byte_data(save_client, 4, tm.tm_mday & 0x7f)
+		|| (i2c_smbus_write_byte_data(save_client, 4, tm.tm_mday & 0x3f)
 			< 0)
-		|| (i2c_smbus_write_byte_data(save_client, 5, tm.tm_mon & 0x7f)
+		|| (i2c_smbus_write_byte_data(save_client, 5, tm.tm_mon & 0x1f)
 			< 0)
-		|| (i2c_smbus_write_byte_data(save_client, 6, tm.tm_year & 0x7f)
+		|| (i2c_smbus_write_byte_data(save_client, 6, tm.tm_year & 0xff)
 			< 0))
 
 		dev_warn(&save_client->dev,"m41t00: can't write to rtc chip\n");
_

Patches currently in -mm which might be from amatus@xxxxxxxxxx are

origin.patch

-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel Newbies FAQ]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Photo]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux