The patch titled
cs5535_gpio.c: call cdev_de()l during module_exit to unmap kobject references and other cleanups
has been added to the -mm tree. Its filename is
drivers-char-cs5535_gpioccall-cdev_del-during-module_exit-to-unmap-kobject-references-and-other-cleanups.patch
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this
From: "Thayumanavar Sachithanantham" <thayumk@xxxxxxxxx>
During module unloading, cdev_del() must be called to unmap cdev related
kobject references and other cleanups(such as inode->i_cdev being set to
NULL) which prevents the OOPS upon subsequent loading, usage and unloading
of modules(as seen in the mail thread
http://marc.theaimsgroup.com/?l=linux-kernel&m=114533640609018&w=2).
Also, remove unneeded test of gpio_base.
Signed-off-by: Thayumanavar Sachithanantham <thayumk@xxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---
drivers/char/cs5535_gpio.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff -puN drivers/char/cs5535_gpio.c~drivers-char-cs5535_gpioccall-cdev_del-during-module_exit-to-unmap-kobject-references-and-other-cleanups drivers/char/cs5535_gpio.c
--- devel/drivers/char/cs5535_gpio.c~drivers-char-cs5535_gpioccall-cdev_del-during-module_exit-to-unmap-kobject-references-and-other-cleanups 2006-04-19 00:49:39.000000000 -0700
+++ devel-akpm/drivers/char/cs5535_gpio.c 2006-04-19 01:14:28.000000000 -0700
@@ -241,9 +241,10 @@ static int __init cs5535_gpio_init(void)
static void __exit cs5535_gpio_cleanup(void)
{
dev_t dev_id = MKDEV(major, 0);
+
+ cdev_del(&cs5535_gpio_cdev);
unregister_chrdev_region(dev_id, CS5535_GPIO_COUNT);
- if (gpio_base != 0)
- release_region(gpio_base, CS5535_GPIO_SIZE);
+ release_region(gpio_base, CS5535_GPIO_SIZE);
}
module_init(cs5535_gpio_init);
_
Patches currently in -mm which might be from thayumk@xxxxxxxxx are
drivers-char-cs5535_gpioccall-cdev_del-during-module_exit-to-unmap-kobject-references-and-other-cleanups.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
