The patch titled
audit: no need to wank with task_lock() and pinning task down in audit_syscall_exit()
has been added to the -mm tree. Its filename is
audit-no-need-to-wank-with-task_lock-and-pinning-task-down-in-audit_syscall_exit.patch
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this
From: Al Viro <viro@xxxxxxxxxxxxxxxx>
Signed-off-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---
kernel/auditsc.c | 10 +---------
1 files changed, 1 insertion(+), 9 deletions(-)
diff -puN kernel/auditsc.c~audit-no-need-to-wank-with-task_lock-and-pinning-task-down-in-audit_syscall_exit kernel/auditsc.c
--- devel/kernel/auditsc.c~audit-no-need-to-wank-with-task_lock-and-pinning-task-down-in-audit_syscall_exit 2006-04-17 21:40:35.000000000 -0700
+++ devel-akpm/kernel/auditsc.c 2006-04-17 21:40:35.000000000 -0700
@@ -329,7 +329,6 @@ static enum audit_state audit_filter_sys
return AUDIT_BUILD_CONTEXT;
}
-/* This should be called with task_lock() held. */
static inline struct audit_context *audit_get_context(struct task_struct *tsk,
int return_valid,
int return_code)
@@ -823,15 +822,10 @@ void audit_syscall_exit(int valid, long
struct task_struct *tsk = current;
struct audit_context *context;
- get_task_struct(tsk);
- task_lock(tsk);
context = audit_get_context(tsk, valid, return_code);
- task_unlock(tsk);
- /* Not having a context here is ok, since the parent may have
- * called __put_task_struct. */
if (likely(!context))
- goto out;
+ return;
if (context->in_syscall && context->auditable)
audit_log_exit(context, tsk);
@@ -849,8 +843,6 @@ void audit_syscall_exit(int valid, long
audit_free_aux(context);
tsk->audit_context = context;
}
- out:
- put_task_struct(tsk);
}
/**
_
Patches currently in -mm which might be from viro@xxxxxxxxxxxxxxxx are
audit-deal-with-deadlocks-in-audit_free.patch
audit-move-call-of-audit_free-into-do_exit.patch
audit-drop-gfp_mask-in-audit_log_exit.patch
audit-drop-task-argument-of-audit_syscall_entryexit.patch
audit-no-need-to-wank-with-task_lock-and-pinning-task-down-in-audit_syscall_exit.patch
slab-leaks3-default-y.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
