On Mon, 23 Mar 2020 at 21:30, Thomas Bogendoerfer
<tsbogend@xxxxxxxxxxxxxxxx> wrote:
>
> On Wed, Mar 04, 2020 at 06:45:25PM +0800, Yousong Zhou wrote:
> > This furthers what commit 42b10815d559 ("MIPS: Don't compile math-emu
> > when CONFIG_MIPS_FP_SUPPORT=n") has done
> >
> > Signed-off-by: Yousong Zhou <yszhou4tech@xxxxxxxxx>
> > ---
> > arch/mips/include/asm/processor.h | 12 ++++++------
> > arch/mips/kernel/process.c | 10 ++++++++--
> > arch/mips/kernel/vdso.c | 26 +++++++++++++++-----------
> > 3 files changed, 29 insertions(+), 19 deletions(-)
> > [...]
>
>
> > - unsigned long base;
> > + unsigned long base = STACK_TOP;
> >
> > - /* Skip the delay slot emulation page */
> > - base = STACK_TOP + PAGE_SIZE;
> > + if (IS_ENABLED(CONFIG_MIPS_FP_EMULATOR)) {
>
> I can't find CONFIG_MIPS_FP_EMULATOR in my tree. So is this really
> the correct ?
>
> > - ret = base;
> > - goto out;
> > + if (IS_ENABLED(CONFIG_MIPS_FP_EMULATOR)) {
>
> same here.
>
> Thomas.
Indeed! "MIPS_FPU_EMULATOR" was previously used by another patch to
make math-emu optional [1]. Now it should be MIPS_FP_SUPPORT. And I
missed both...
[1] MIPS: make FPU emulator optional,
https://www.linux-mips.org/archives/linux-mips/2014-04/msg00062.html
Regards,
yousong
